You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "wjddn279 (via GitHub)" <gi...@apache.org> on 2026/03/24 06:39:20 UTC
[PR] Update cncf's import conf path to use common compat SDK [airflow]
wjddn279 opened a new pull request, #64143:
URL: https://github.com/apache/airflow/pull/64143
related: https://github.com/apache/airflow/issues/60000
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on PR #64143:
URL: https://github.com/apache/airflow/pull/64143#issuecomment-4166781276
@jason810496 ci green! I think it's ok to merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r3007997928
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -49,7 +49,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
self.airflow_home = AIRFLOW_HOME
self.dags_folder = self._conf.get(self.core_section, "dags_folder")
self.parallelism = self._conf.getint(self.core_section, "parallelism")
- self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback=None)
+ self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback="")
Review Comment:
Thanks for the clarification, then I will prefer to defer this one until https://github.com/apache/airflow/pull/64209 is merged. Let's see if your current change rebase on top of #64209 without any fallback changes will pass or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on PR #64143:
URL: https://github.com/apache/airflow/pull/64143#issuecomment-4140675297
@jason810496
I think the review has resolved and there is no issue! Can you review once more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2985994410
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -112,9 +111,7 @@ def __init__(self, *args, **kwargs):
self.last_handled: dict[TaskInstanceKey, float] = {}
self.kubernetes_queue: str | None = None
self.task_publish_retries: Counter[TaskInstanceKey] = Counter()
- self.task_publish_max_retries = self.conf.getint(
- "kubernetes_executor", "task_publish_max_retries", fallback=0
- )
+ self.task_publish_max_retries = self.conf.getint("kubernetes_executor", "task_publish_max_retries")
Review Comment:
Should this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 merged PR #64143:
URL: https://github.com/apache/airflow/pull/64143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2986052880
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -89,9 +89,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
# create, watch, get, and delete pods in this namespace.
self.kube_namespace = self._conf.get(self.kubernetes_section, "namespace")
self.multi_namespace_mode = self._conf.getboolean(self.kubernetes_section, "multi_namespace_mode")
- multi_ns_list = self._conf.get(
- self.kubernetes_section, "multi_namespace_mode_namespace_list", fallback=""
- )
+ multi_ns_list = self._conf.get(self.kubernetes_section, "multi_namespace_mode_namespace_list")
Review Comment:
In this [PR](https://github.com/apache/airflow/pull/62696), `airflow.sdk.configuration` was updated to also read from `provider_config_fallback_defaults.cfg` and populate the default values. I removed the fallback since, outside of tests, the default values will be read from `provider.yaml`, making the fallback unnecessary.
@jason810496 I'm a bit confused about the scope of the changes. I removed the fallback only for the values that exist in `provider_config_fallback_defaults.cfg` — is that correct? Or should I just leave them as they were?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2999389206
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -89,9 +89,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
# create, watch, get, and delete pods in this namespace.
self.kube_namespace = self._conf.get(self.kubernetes_section, "namespace")
self.multi_namespace_mode = self._conf.getboolean(self.kubernetes_section, "multi_namespace_mode")
- multi_ns_list = self._conf.get(
- self.kubernetes_section, "multi_namespace_mode_namespace_list", fallback=""
- )
+ multi_ns_list = self._conf.get(self.kubernetes_section, "multi_namespace_mode_namespace_list")
Review Comment:
Yes, I checked the three key where the fallback was removed (`multi_namespace_mode_namespace_list`, `pod_template_file`, `namespace`) and the defaults are explicitly specified in `providers.yaml` and the values also exist in `provider_config_fallback_defaults.cfg`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "Nataneljpwd (via GitHub)" <gi...@apache.org>.
Nataneljpwd commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2999502767
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/template_rendering.py:
##########
Review Comment:
Alright
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2994938520
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -89,9 +89,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
# create, watch, get, and delete pods in this namespace.
self.kube_namespace = self._conf.get(self.kubernetes_section, "namespace")
self.multi_namespace_mode = self._conf.getboolean(self.kubernetes_section, "multi_namespace_mode")
- multi_ns_list = self._conf.get(
- self.kubernetes_section, "multi_namespace_mode_namespace_list", fallback=""
- )
+ multi_ns_list = self._conf.get(self.kubernetes_section, "multi_namespace_mode_namespace_list")
Review Comment:
If the existing value for `fallback` is same as the value in `provider.yaml` and in `provider_config_fallback_defaults, then we can safely remove the `fallback`.
But if not fulfill any one of the above default value, then I will suggest to keep it as it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2999377683
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/template_rendering.py:
##########
Review Comment:
After reviewing the logic, it turns out we shouldn't remove it. This logic was written to support multi-team, and `from airflow.executors.base_executor import ExecutorConf` is only available from version 3.2.0 onwards. If we remove the except block, it will break backward compatibility with earlier versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on PR #64143:
URL: https://github.com/apache/airflow/pull/64143#issuecomment-4151514395
@jason810496
I've done reverting the fallback! Maybe looks good and CI is green!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2986005520
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -89,9 +89,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
# create, watch, get, and delete pods in this namespace.
self.kube_namespace = self._conf.get(self.kubernetes_section, "namespace")
self.multi_namespace_mode = self._conf.getboolean(self.kubernetes_section, "multi_namespace_mode")
- multi_ns_list = self._conf.get(
- self.kubernetes_section, "multi_namespace_mode_namespace_list", fallback=""
- )
+ multi_ns_list = self._conf.get(self.kubernetes_section, "multi_namespace_mode_namespace_list")
Review Comment:
Same here (and multiple below), removing `fallback` would make these potentially raise, is this intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "Nataneljpwd (via GitHub)" <gi...@apache.org>.
Nataneljpwd commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2992738955
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/template_rendering.py:
##########
Review Comment:
Why do we need the except for import error here? I think it was there for before the common compat was introduced, and probably can be removed as the provider handles the import error and falls back to af 2 import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r3013015695
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -49,7 +49,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
self.airflow_home = AIRFLOW_HOME
self.dags_folder = self._conf.get(self.core_section, "dags_folder")
self.parallelism = self._conf.getint(self.core_section, "parallelism")
- self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback=None)
+ self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback="")
Review Comment:
https://github.com/apache/airflow/pull/64209 was merged yesterday, could you please rebase when you have a moment? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r3007364277
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -49,7 +49,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
self.airflow_home = AIRFLOW_HOME
self.dags_folder = self._conf.get(self.core_section, "dags_folder")
self.parallelism = self._conf.getint(self.core_section, "parallelism")
- self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback=None)
+ self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback="")
Review Comment:
Should we fallback to `None` instead of `""` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r3007378662
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -49,7 +49,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
self.airflow_home = AIRFLOW_HOME
self.dags_folder = self._conf.get(self.core_section, "dags_folder")
self.parallelism = self._conf.getint(self.core_section, "parallelism")
- self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback=None)
+ self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback="")
Review Comment:
After testing, I found that when the fallback is triggered and the value is None, it causes an error in the tests. It's this part.
https://github.com/apache/airflow/blob/6d8ccc687b64aca6841e5c9976799be9c364345c/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/cli/kubernetes_command.py#L109
This PR (https://github.com/apache/airflow/pull/64209) likely eliminates the case where the fallback is triggered in test, but you can think of this change as a fix for the case where None is passed in and causes an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r3007390238
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -49,7 +49,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
self.airflow_home = AIRFLOW_HOME
self.dags_folder = self._conf.get(self.core_section, "dags_folder")
self.parallelism = self._conf.getint(self.core_section, "parallelism")
- self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback=None)
+ self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback="")
Review Comment:
Without changing it to a blank string, it currently throws an error as-is.
<img width="1598" height="74" alt="image" src="https://github.com/user-attachments/assets/43c5a90c-93f6-40c0-b010-ca56261963ac" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2993012977
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/template_rendering.py:
##########
Review Comment:
There's no particular reason. I didn't change it because I'm not sure of the intent behind the existing logic (and it also seems outside the scope of this work).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #64143:
URL: https://github.com/apache/airflow/pull/64143#issuecomment-4147766982
> Wait, I realized that we still need those fallback to keep it compatible or we might cause breaking change for users who using older Airflow in the last minute.
>
> Let me explain why: users could still use latest providers in "older" Airflow Core (e.g. Airflow `3.1` or `2.11`), for the `conf` in older Airflow version, they don't respect the `provider.yaml`.
That is the reason why we have the "common.compat" provider - to abstract the Airflow backend version away. So as the change is made and depednency in modelled in provider.yaml this should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #64143:
URL: https://github.com/apache/airflow/pull/64143#issuecomment-4117704247
@wjddn279 This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
**Issues found:**
- :x: **Provider tests**: Failing: provider distributions tests / Compat 2.11.1:P3.10:, provider distributions tests / Compat 3.0.6:P3.10:, provider distributions tests / Compat 3.1.8:P3.10:, Non-DB tests: providers / Non-DB-prov::3.10:amazon...google. Run provider tests with `breeze run pytest <provider-test-path> -xvs`. See [Provider tests docs](https://github.com/apache/airflow/blob/main/contributing-docs/12_provider_distributions.rst).
- :x: **Kubernetes tests**: Failing: Low dep tests: providers / All-prov:LowestDeps:14:3.10:cncf.kubernetes. See the K8s testing documentation. See [Kubernetes tests docs](https://github.com/apache/airflow/blob/main/contributing-docs/09_testing.rst).
**What to do next:**
- The comment informs you what you need to do.
- Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
- There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates.
- Maintainers will then proceed with a normal review.
Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r3014014335
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -49,7 +49,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
self.airflow_home = AIRFLOW_HOME
self.dags_folder = self._conf.get(self.core_section, "dags_folder")
self.parallelism = self._conf.getint(self.core_section, "parallelism")
- self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback=None)
+ self.pod_template_file = self._conf.get(self.kubernetes_section, "pod_template_file", fallback="")
Review Comment:
maybe https://github.com/apache/airflow/pull/64524 can resolve the mypy checks error..
After merging it, I'll rebase it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on PR #64143:
URL: https://github.com/apache/airflow/pull/64143#issuecomment-4118408391
@jason810496
Hi Jason. As intended by this [PR](https://github.com/apache/airflow/pull/62696), I removed the fallback from the existing logic. Currently, the compat tests for the previous version are failing — is that expected? I believe it's because the older version doesn't have the functionality to read from `provider_config_fallback_defaults.cfg`.
Am I misunderstanding something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cncf's import conf path to use common compat SDK [airflow]
Posted by "Nataneljpwd (via GitHub)" <gi...@apache.org>.
Nataneljpwd commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r2993307470
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/template_rendering.py:
##########
Review Comment:
Don't know about how out of scope it is, you can just remove it, as it is a very small change and relates to the import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org