[GitHub] [netbeans] sdedic commented on a diff in pull request #4184: Maven / dependency query fixes.

[GitBox <gi...@apache.org>]

sdedic commented on code in PR #4184:
URL: https://github.com/apache/netbeans/pull/4184#discussion_r887745484


##########
ide/project.dependency/src/org/netbeans/modules/project/dependency/DependencyResult.java:
##########
@@ -45,8 +46,18 @@ public interface DependencyResult extends Lookup.Provider {
      */
     public Dependency getRoot();
     
+    /**
+     * Checks if the data is still valid
+     * @return true, if the data is valid
+     */
     public boolean isValid();
     
+    /**
+     * Returns artifacts that may be unavailable or erroneous.
+     * @return problem artifacts
+     */
+    public Collection<ArtifactSpec> getProblemArtifacts();
+    

Review Comment:
   They can be ... but they are 'problematic' :) e.g. they do not have the `getFile()` valid / filled in. Or some other issue like version conflict. Maybe this could rather identify the `Dependency` structure -- which means an exact position in the tree  ?



##########
ide/project.dependency/src/org/netbeans/modules/project/dependency/ArtifactSpec.java:
##########
@@ -62,9 +63,10 @@ public enum VersionKind {
     private final String versionSpec;
     private final String classifier;
     private final boolean optional;
+    private final FileObject localFile;
     final T data;
 
-    ArtifactSpec(VersionKind kind, String groupId, String artifactId, String versionSpec, String type, String classifier, boolean optional, T impl) {
+    ArtifactSpec(VersionKind kind, String groupId, String artifactId, String versionSpec, String type, String classifier, boolean optional, FileObject localFile, T impl) {

Review Comment:
   Yes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists