You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/10 02:30:37 UTC
[GitHub] [spark] viirya opened a new pull request, #36491: [SPARK-XXXXX][SS] Add custom metric of skipped null values for stream join operator
viirya opened a new pull request, #36491:
URL: https://github.com/apache/spark/pull/36491
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This proposes to add a custom metric of skipped null values for stream-stream join operator.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When `STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS` is enabled, Spark will skip null values in hash-based stream-stream joins. But currently we cannot track if this is happened and how many it is. For our customers, they have an interest to know the number of values skipped for better tracking purpose.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. One custom metric is added to stream-stream join if the config is enabled. As the config is disabled by default, it is 'no' for users by default.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
As this is for a abnormal case when accessing the states, it seems hard to unit test it. This doesn't change other logic/behavior of current operator but adds a metric. This should pass all existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #36491:
URL: https://github.com/apache/spark/pull/36491#issuecomment-1122967228
Thank you @dongjoon-hyun @anishshri-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869697721
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala:
##########
@@ -617,6 +619,7 @@ class SymmetricHashJoinStateManager(
val keyWithIndex = keyWithIndexRow(key, index)
val valuePair = valueRowConverter.convertValue(stateStore.get(keyWithIndex))
if (valuePair == null && storeConf.skipNullsForStreamStreamJoins) {
+ skippedNullValueCount.map(_ += 1L)
Review Comment:
I was added it in early commit, but removed it as that is for removing old states. I think the interest is to know how many times null values are happened during joining.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869698818
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1927,7 +1927,8 @@ object SQLConf {
val STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS =
buildConf("spark.sql.streaming.stateStore.skipNullsForStreamStreamJoins.enabled")
.internal()
- .doc("When true, this config will skip null values in hash based stream-stream joins.")
+ .doc("When true, this config will skip null values in hash based stream-stream joins. " +
+ "The number of skipped null values will be shown as custom metric of stream join operator.")
Review Comment:
Oh, if you're asking about the output of the metric, it is just as other metrics you can see in SQL UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #36491:
URL: https://github.com/apache/spark/pull/36491#issuecomment-1122825251
Re-ran all CI tasks and they were passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
URL: https://github.com/apache/spark/pull/36491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anishshri-db commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
anishshri-db commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869691484
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala:
##########
@@ -617,6 +619,7 @@ class SymmetricHashJoinStateManager(
val keyWithIndex = keyWithIndexRow(key, index)
val valuePair = valueRowConverter.convertValue(stateStore.get(keyWithIndex))
if (valuePair == null && storeConf.skipNullsForStreamStreamJoins) {
+ skippedNullValueCount.map(_ += 1L)
Review Comment:
We also skip null values in `findNextValueForIndex` function as well:
```
private def findNextValueForIndex(): ValueAndMatchPair = {
// Loop across all values for the current key, and then all other keys, until we find a
// value satisfying the removal condition.
def hasMoreValuesForCurrentKey = currentKey != null && index < numValues
def hasMoreKeys = allKeyToNumValues.hasNext
while (hasMoreValuesForCurrentKey || hasMoreKeys) {
if (hasMoreValuesForCurrentKey) {
// First search the values for the current key.
val valuePair = keyWithIndexToValue.get(currentKey, index)
if (valuePair == null && storeConf.skipNullsForStreamStreamJoins) {
index += 1
```
Do we want to track these skips as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anishshri-db commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
anishshri-db commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869700192
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1927,7 +1927,8 @@ object SQLConf {
val STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS =
buildConf("spark.sql.streaming.stateStore.skipNullsForStreamStreamJoins.enabled")
.internal()
- .doc("When true, this config will skip null values in hash based stream-stream joins.")
+ .doc("When true, this config will skip null values in hash based stream-stream joins. " +
+ "The number of skipped null values will be shown as custom metric of stream join operator.")
Review Comment:
Yes correct. Ok cool - the metrics are not logged anywhere is it ? Only available in the UI ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #36491:
URL: https://github.com/apache/spark/pull/36491#issuecomment-1122827476
cc @HeartSaVioR @dongjoon-hyun @sunchao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #36491:
URL: https://github.com/apache/spark/pull/36491#issuecomment-1123022257
Thanks @HeartSaVioR !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #36491:
URL: https://github.com/apache/spark/pull/36491#issuecomment-1123022403
Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anishshri-db commented on pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
anishshri-db commented on PR #36491:
URL: https://github.com/apache/spark/pull/36491#issuecomment-1122939429
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869701565
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1927,7 +1927,8 @@ object SQLConf {
val STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS =
buildConf("spark.sql.streaming.stateStore.skipNullsForStreamStreamJoins.enabled")
.internal()
- .doc("When true, this config will skip null values in hash based stream-stream joins.")
+ .doc("When true, this config will skip null values in hash based stream-stream joins. " +
+ "The number of skipped null values will be shown as custom metric of stream join operator.")
Review Comment:
It will be in `StateOperatorProgress`'s `customMetrics` too, as it is `customStatefulOperatorMetrics`. So streaming query listener can access it too besides UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869697721
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala:
##########
@@ -617,6 +619,7 @@ class SymmetricHashJoinStateManager(
val keyWithIndex = keyWithIndexRow(key, index)
val valuePair = valueRowConverter.convertValue(stateStore.get(keyWithIndex))
if (valuePair == null && storeConf.skipNullsForStreamStreamJoins) {
+ skippedNullValueCount.map(_ += 1L)
Review Comment:
I added it in early commit, but removed it as that is for removing old states. I think the interest is to know how many times null values are happened during joining.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anishshri-db commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
anishshri-db commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869693275
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1927,7 +1927,8 @@ object SQLConf {
val STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS =
buildConf("spark.sql.streaming.stateStore.skipNullsForStreamStreamJoins.enabled")
.internal()
- .doc("When true, this config will skip null values in hash based stream-stream joins.")
+ .doc("When true, this config will skip null values in hash based stream-stream joins. " +
+ "The number of skipped null values will be shown as custom metric of stream join operator.")
Review Comment:
Could you paste an output of what this looks like in the PR description ? Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869707965
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1927,7 +1927,8 @@ object SQLConf {
val STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS =
buildConf("spark.sql.streaming.stateStore.skipNullsForStreamStreamJoins.enabled")
.internal()
- .doc("When true, this config will skip null values in hash based stream-stream joins.")
+ .doc("When true, this config will skip null values in hash based stream-stream joins. " +
+ "The number of skipped null values will be shown as custom metric of stream join operator.")
Review Comment:
I don't have UI output now. I don't own the stream job. As the change follows existing metric framework so I think if the unit test makes sure metric is updated, it should be as expected in places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869701565
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1927,7 +1927,8 @@ object SQLConf {
val STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS =
buildConf("spark.sql.streaming.stateStore.skipNullsForStreamStreamJoins.enabled")
.internal()
- .doc("When true, this config will skip null values in hash based stream-stream joins.")
+ .doc("When true, this config will skip null values in hash based stream-stream joins. " +
+ "The number of skipped null values will be shown as custom metric of stream join operator.")
Review Comment:
It will be in `StateOperatorProgress`'s `customMetrics` too, as `customStatefulOperatorMetrics`. So streaming query listener can access it too besides UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anishshri-db commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
anishshri-db commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869702402
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1927,7 +1927,8 @@ object SQLConf {
val STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS =
buildConf("spark.sql.streaming.stateStore.skipNullsForStreamStreamJoins.enabled")
.internal()
- .doc("When true, this config will skip null values in hash based stream-stream joins.")
+ .doc("When true, this config will skip null values in hash based stream-stream joins. " +
+ "The number of skipped null values will be shown as custom metric of stream join operator.")
Review Comment:
Do you have output for that ? or is it not easy to reproduce ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anishshri-db commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
anishshri-db commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869716877
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1927,7 +1927,8 @@ object SQLConf {
val STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS =
buildConf("spark.sql.streaming.stateStore.skipNullsForStreamStreamJoins.enabled")
.internal()
- .doc("When true, this config will skip null values in hash based stream-stream joins.")
+ .doc("When true, this config will skip null values in hash based stream-stream joins. " +
+ "The number of skipped null values will be shown as custom metric of stream join operator.")
Review Comment:
Cool sounds good. Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869698328
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1927,7 +1927,8 @@ object SQLConf {
val STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS =
buildConf("spark.sql.streaming.stateStore.skipNullsForStreamStreamJoins.enabled")
.internal()
- .doc("When true, this config will skip null values in hash based stream-stream joins.")
+ .doc("When true, this config will skip null values in hash based stream-stream joins. " +
+ "The number of skipped null values will be shown as custom metric of stream join operator.")
Review Comment:
Please let me know what output you are looking for? The output of this doc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anishshri-db commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
anishshri-db commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869700192
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1927,7 +1927,8 @@ object SQLConf {
val STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS =
buildConf("spark.sql.streaming.stateStore.skipNullsForStreamStreamJoins.enabled")
.internal()
- .doc("When true, this config will skip null values in hash based stream-stream joins.")
+ .doc("When true, this config will skip null values in hash based stream-stream joins. " +
+ "The number of skipped null values will be shown as custom metric of stream join operator.")
Review Comment:
Yes correct. Ok cool - the metrics are not logged anywhere is it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anishshri-db commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator
Posted by GitBox <gi...@apache.org>.
anishshri-db commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869698764
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala:
##########
@@ -617,6 +619,7 @@ class SymmetricHashJoinStateManager(
val keyWithIndex = keyWithIndexRow(key, index)
val valuePair = valueRowConverter.convertValue(stateStore.get(keyWithIndex))
if (valuePair == null && storeConf.skipNullsForStreamStreamJoins) {
+ skippedNullValueCount.map(_ += 1L)
Review Comment:
Ok sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org