You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/14 21:38:32 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #2675: Core: add key_metadata to ManifestFile spec

rdblue commented on a change in pull request #2675:
URL: https://github.com/apache/iceberg/pull/2675#discussion_r651295477



##########
File path: api/src/test/java/org/apache/iceberg/TestHelpers.java
##########
@@ -346,6 +350,11 @@ public Long deletedRowsCount() {
       return partitions;
     }
 
+    @Override
+    public ByteBuffer keyMetadata() {

Review comment:
       Is this used in tests? We could just allow this to use the default implementation, unless we added tests that exercise it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org