[GitHub] fabianmenges commented on issue #3437: Feature: Display the verbose name for metrics within Charts and legend.

[gi...@git.apache.org]

fabianmenges commented on issue #3437: Feature: Display the verbose name for metrics within Charts and legend.
URL: https://github.com/apache/incubator-superset/pull/3437#issuecomment-329559860
 
 
   Interesting, I'll write some unit tests for the unicode character problem and check it. I can always B64 encode the dict keys. 
   We can pass down flags if and how to use the verbose name to python, that way visualizations that want to do something more complex with the names can do whatever they want. 
   In general if feel like if users go through the trouble of manually specifying verbose names they want them to be used. 
   
   I'm not super worried about name collisions since you have to manually set verbose names anyways and it should be pretty clear to anyone who can setup a datasource that creating verbose names with collision is problematic and I don't think there is a use case for doing that. 
   Regardless its obviously something we can test for on data entry: "verbose name" needs to be unique and they are not allowed to collide with any of the column names.
   
   We could try to go a different route and move logic [like this](https://github.com/tc-dc/superset/blob/6525225eae6b17a1495bec61ac4dd57054e9f4a7/superset/viz.py#L850) into JS and the data object that the explore_json endpoint returns would have a complex Json object as series_title. However that only moves the problem to JS and doesn't really solve it.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services