You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/10/09 01:48:47 UTC
Re: Review Request: Changing FilesProcess to use async io::read
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7048/#review12254
-----------------------------------------------------------
discussed with benh, the current read is ok, I will do the following:
-Cap the read size at 16k.
-Update the pailer documentation to indicate the lack of 'length' in the response.
-Double check that the read is ok with partial data
- Ben Mahler
On Sept. 14, 2012, midnight, Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7048/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2012, midnight)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> see above
>
> also:
> -removed redundant length field from json
> -added missing test for buffered io::read
>
>
> Diffs
> -----
>
> src/files/files.cpp 806aa35
> src/tests/files_tests.cpp 6ef2004
> src/webui/master/static/jquery.pailer.js edd23d9
> third_party/libprocess/include/process/io.hpp 722b15f
> third_party/libprocess/src/process.cpp 2d2b56c
> third_party/libprocess/src/tests.cpp 41bf973
>
> Diff: https://reviews.apache.org/r/7048/diff/
>
>
> Testing
> -------
>
> make check on osx, and redhat
>
> mesos-local.sh to verify pailer
>
>
> Thanks,
>
> Ben Mahler
>
>