[GitHub] [hbase] gkanade commented on a change in pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

[GitBox <gi...@apache.org>]

gkanade commented on a change in pull request #2483:
URL: https://github.com/apache/hbase/pull/2483#discussion_r521570113



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -3481,6 +3512,9 @@ public ScanResponse scan(final RpcController controller, final ScanRequest reque
       }
       throw new ServiceException(e);
     }
+    if(rsh.isFullRegionScan) {
+      rpcFullScanRequestCount.increment();

Review comment:
       this is called in the scan method, same place as where we increment rpcScanRequestCount, so yes it should happen only for scan. @anoopsjohn to verify.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org