You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2022/08/02 07:55:43 UTC

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18805


Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................

IMPALA-11467: Force Boost to use /dev/random for UUID generation

To avoid crash issue at OS with kernel lower than Linux 3.17, this patch
pick kudu's solution 35b5664f908cd1250c9f01e5dff77b653cfd12b7 into impala.

Testing:
 - run pre-built impalad at CentOS 7 kernel 3.10 with no crash.

Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
---
M be/CMakeLists.txt
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/18805/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 19:53:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 4: Code-Review+2

This makes sense to me


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 20:03:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 4: Code-Review+1

Rebased this change, carrying +1s from Michael and Alexey

I'm kicking off a test run for this, and I think this change makes sense.


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 22:42:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8387/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Aug 2022 08:00:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8515/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 03:21:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11138/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 12:10:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 16:29:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 4:

The test failure is not related to this change. Rerunning.


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 03:21:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 07:57:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11071/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Aug 2022 08:16:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8514/


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 03:19:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 20:09:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8514/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 22:42:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Aug 2022 12:56:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 16:30:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18805 )

Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation
......................................................................

IMPALA-11467: Force Boost to use /dev/random for UUID generation

To avoid crash issue at OS with kernel lower than Linux 3.17, this patch
pick kudu's solution 35b5664f908cd1250c9f01e5dff77b653cfd12b7 into impala.

Testing:
 - run pre-built impalad at CentOS 7 kernel 3.10 with no crash.

Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Reviewed-on: http://gerrit.cloudera.org:8080/18805
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M be/CMakeLists.txt
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Alexey Serbin: Looks good to me, but someone else must approve
  Joe McDonnell: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8
Gerrit-Change-Number: 18805
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>