You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/20 04:14:00 UTC

[GitHub] [incubator-superset] rusackas commented on a change in pull request #11160: refactor: Replace react-bootstrap Tabs with Antd Tabs in DashboardBuilder

rusackas commented on a change in pull request #11160:
URL: https://github.com/apache/incubator-superset/pull/11160#discussion_r508198525



##########
File path: superset-frontend/stylesheets/superset.less
##########
@@ -279,18 +279,20 @@ table.table-no-hover tr:hover {
   }
 }
 
-.nav.nav-tabs li .anchor-link-container {
-  top: 0;
-  right: -32px;
-}
-
 .dashboard-component.dashboard-component-header .anchor-link-container {
   .fa.fa-link {
     font-size: @font-size-l;
   }
 }
 
-.nav.nav-tabs li:hover,
+.ant-tabs-nav-list .ant-tabs-tab {

Review comment:
       Would much rather see this moved into Emotion, in the `Tabs` component, and using `gridUnit * 3` instead of `12`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org