You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/06 13:53:10 UTC
[GitHub] [iotdb] CRZbulabula opened a new pull request, #7254: [IOTDB-4223] Maintain default node ip config
CRZbulabula opened a new pull request, #7254:
URL: https://github.com/apache/iotdb/pull/7254
We make some constraints on node ip addresses:
1. DataNode's rpc_address: could set 0.0.0.0, 127.0.0.1 or ipv4 address(default is 0.0.0.0)
2. DataNode's internal_address: could set 0.0.0.0, 127.0.0.1 or ipv4 address(default is 0.0.0.0)
3. DataNode's target_config_nodes: the ip should never be 0.0.0.0(default is 127.0.0.1)
4. ConfigNode's internal_address: could set 0.0.0.0, 127.0.0.1 or ipv4 address(default is 0.0.0.0)
5. ConfigNode's target_config_nodes: the ip should never be 0.0.0.0(default is 127.0.0.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes merged pull request #7254: [IOTDB-4223] Maintain default node ip config
Posted by GitBox <gi...@apache.org>.
Beyyes merged PR #7254:
URL: https://github.com/apache/iotdb/pull/7254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes commented on a diff in pull request #7254: [IOTDB-4223] Maintain default node ip config
Posted by GitBox <gi...@apache.org>.
Beyyes commented on code in PR #7254:
URL: https://github.com/apache/iotdb/pull/7254#discussion_r964332193
##########
node-commons/src/main/java/org/apache/iotdb/commons/utils/NodeUrlUtils.java:
##########
@@ -187,4 +187,11 @@ public static List<TConfigNodeLocation> parseTConfigNodeUrls(String configNodeUr
throws BadNodeUrlException {
return parseTConfigNodeUrls(Arrays.asList(configNodeUrls.split(";")));
}
+
+ public static boolean isLocalAddress(String ip) {
+ if (ip == null) {
+ return false;
+ }
+ return ip.equals("0.0.0.0") || ip.equals("127.0.0.1") || ip.equals("localhost");
Review Comment:
`0.0.0.0`, `127.0.0.1`, `localhost` can be set to static final variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org