You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ta...@apache.org on 2023/03/16 00:57:17 UTC

[superset] branch nytai-patch-2 created (now 4e3aa42307)

This is an automated email from the ASF dual-hosted git repository.

tai pushed a change to branch nytai-patch-2
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 4e3aa42307 fix: update default WEBDRIVER_OPTION_ARGS

This branch includes the following new commits:

     new 4e3aa42307 fix: update default WEBDRIVER_OPTION_ARGS

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[superset] 01/01: fix: update default WEBDRIVER_OPTION_ARGS

Posted by ta...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

tai pushed a commit to branch nytai-patch-2
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 4e3aa42307fd4abca027b43fba151d606f47ad15
Author: ʈᵃᵢ <td...@gmail.com>
AuthorDate: Wed Mar 15 17:57:10 2023 -0700

    fix: update default WEBDRIVER_OPTION_ARGS
---
 superset/config.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/superset/config.py b/superset/config.py
index 9643f30883..ec0ddb0ad7 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -1302,9 +1302,8 @@ WEBDRIVER_AUTH_FUNC = None
 WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {"service_log_path": "/dev/null"}
 
 # Additional args to be passed as arguments to the config object
-# Note: these options are Chrome-specific. For FF, these should
-# only include the "--headless" arg
-WEBDRIVER_OPTION_ARGS = ["--headless", "--marionette"]
+# Note: If using Chrome, you'll want to add the "--marionette" arg.
+WEBDRIVER_OPTION_ARGS = ["--headless"]
 
 # The base URL to query for accessing the user interface
 WEBDRIVER_BASEURL = "http://0.0.0.0:8080/"