You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Kris20030907 (via GitHub)" <gi...@apache.org> on 2025/02/23 13:38:19 UTC
[PR] fix: cleanup dead code patterns and improve readability and maintainability. [rocketmq]
Kris20030907 opened a new pull request, #9202:
URL: https://github.com/apache/rocketmq/pull/9202
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #9201
### Brief Description
- if (true) return patterns are redundant and misleading
- Unreachable throw statements clutter code and may cause static analysis warnings
- Cleanup improves code readability and maintainability
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
Just modify the code format, not the logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9201] cleanup dead code patterns and improve readability and maintainability. [rocketmq]
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #9202:
URL: https://github.com/apache/rocketmq/pull/9202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9201] cleanup dead code patterns and improve readability and maintainability. [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9202:
URL: https://github.com/apache/rocketmq/pull/9202#issuecomment-2676880794
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9202?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 48.04%. Comparing base [(`119a0be`)](https://app.codecov.io/gh/apache/rocketmq/commit/119a0bec66375b721aa935675c5ad0a11838445a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1ac3957`)](https://app.codecov.io/gh/apache/rocketmq/commit/1ac3957711864361ee784c1b2401d95174dc8a1d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 21 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #9202 +/- ##
=============================================
- Coverage 48.11% 48.04% -0.07%
- Complexity 12086 12091 +5
=============================================
Files 1320 1321 +1
Lines 92840 93030 +190
Branches 11898 11923 +25
=============================================
+ Hits 44670 44699 +29
- Misses 42671 42802 +131
- Partials 5499 5529 +30
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9202?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org