You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/09/15 12:30:35 UTC
[GitHub] [brooklyn-ui] zan-mateusz opened a new pull request #288: ensuring that tosca post processors are not applied if type is camp
zan-mateusz opened a new pull request #288:
URL: https://github.com/apache/brooklyn-ui/pull/288
For support of both camp and tosca types at the same time:
Previously:
camp type had a post processor applied to it, that translated it to tosca
API to process the deployment on the server side received the tosca 1.3 template with format as tosca13
server translate the template back to camp and deploys the application
Above is unnecessary conversion back and forward and also has some side effects (such as an unnecessary delete effector).
With the change:
if using camp type, we don't apply post processors
API sends a camp template to the server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] jathanasiou commented on a change in pull request #288: ensuring that tosca post processors are not applied if type is camp
Posted by GitBox <gi...@apache.org>.
jathanasiou commented on a change in pull request #288:
URL: https://github.com/apache/brooklyn-ui/pull/288#discussion_r709172203
##########
File path: ui-modules/utils/quick-launch/quick-launch.js
##########
@@ -150,8 +150,8 @@ export function quickLaunchDirective() {
function deployApp() {
$scope.deploying = true;
-
- Promise.resolve(quickLaunch.buildYaml())
+ let useExtensions = $scope.app.plan.format.includes('camp') ? false : true;
+ Promise.resolve(quickLaunch.buildYaml(useExtensions))
Review comment:
`includes` returns boolean so much less redundant to simply do:
Promise.resolve(quickLaunch.buildYaml(!$scope.app.plan.format.includes('camp')))
Pretty good otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] asfgit merged pull request #288: ensuring that tosca post processors are not applied if type is camp
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #288:
URL: https://github.com/apache/brooklyn-ui/pull/288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] zan-mateusz commented on a change in pull request #288: ensuring that tosca post processors are not applied if type is camp
Posted by GitBox <gi...@apache.org>.
zan-mateusz commented on a change in pull request #288:
URL: https://github.com/apache/brooklyn-ui/pull/288#discussion_r709275031
##########
File path: ui-modules/utils/quick-launch/quick-launch.js
##########
@@ -150,8 +150,8 @@ export function quickLaunchDirective() {
function deployApp() {
$scope.deploying = true;
-
- Promise.resolve(quickLaunch.buildYaml())
+ let useExtensions = $scope.app.plan.format.includes('camp') ? false : true;
+ Promise.resolve(quickLaunch.buildYaml(useExtensions))
Review comment:
addressed the comment. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org