You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/06 11:34:44 UTC
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on a change in pull
request #13: Remove component name
wu-sheng commented on a change in pull request #13: Remove component name
URL: https://github.com/apache/skywalking-agent-test-tool/pull/13#discussion_r404022023
##########
File path: mock-collector/src/main/java/org/apache/skywalking/plugin/test/mockcollector/mock/MockManagementService.java
##########
@@ -23,12 +23,13 @@
import org.apache.skywalking.apm.network.management.v3.InstancePingPkg;
import org.apache.skywalking.apm.network.management.v3.InstanceProperties;
import org.apache.skywalking.apm.network.management.v3.ManagementServiceGrpc;
+import org.apache.skywalking.plugin.test.mockcollector.entity.ValidateData;
public class MockManagementService extends ManagementServiceGrpc.ManagementServiceImplBase {
@Override
public void reportInstanceProperties(InstanceProperties request, StreamObserver<Commands> responseObserver) {
-
+ ValidateData.INSTANCE.register();
Review comment:
Do we verify this? Didn't see this in the expected file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services