You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Chinna Rao Lalam (JIRA)" <ji...@apache.org> on 2011/05/25 08:54:47 UTC
[jira] [Created] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
-------------------------------------------------------------------
Key: HIVE-2184
URL: https://issues.apache.org/jira/browse/HIVE-2184
Project: Hive
Issue Type: Bug
Components: Metastore
Affects Versions: 0.5.0, 0.8.0
Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
Reporter: Chinna Rao Lalam
Assignee: Chinna Rao Lalam
1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-2184:
-----------------------------
Resolution: Fixed
Fix Version/s: 0.9.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Chinna!
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.9.0
>
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.2.patch, HIVE-2184.3.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-2184:
-----------------------------
Status: Open (was: Patch Available)
Sorry, this one has gone stale...could you rebase against trunk?
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2184:
-----------------------------------
Status: Patch Available (was: Open)
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.2.patch, HIVE-2184.3.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2184:
-----------------------------------
Status: Patch Available (was: Open)
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094202#comment-13094202 ]
John Sichi commented on HIVE-2184:
----------------------------------
+1. Will commit when tests pass.
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.2.patch, HIVE-2184.3.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2184:
-----------------------------------
Attachment: HIVE-2184.patch
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-2184:
-----------------------------
Status: Open (was: Patch Available)
Comments added on review board
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2184:
-----------------------------------
Status: Patch Available (was: Open)
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088891#comment-13088891 ]
jiraposter@reviews.apache.org commented on HIVE-2184:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1088/
-----------------------------------------------------------
(Updated 2011-08-22 18:23:44.041004)
Review request for hive and John Sichi.
Changes
-------
Fixed review comments and updated the patch.
Summary
-------
Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
This addresses bug HIVE-2184.
https://issues.apache.org/jira/browse/HIVE-2184
Diffs (updated)
-----
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1154844
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1154844
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1154844
Diff: https://reviews.apache.org/r/1088/diff
Testing
-------
Ran all the testcases
Thanks,
chinna
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.2.patch, HIVE-2184.3.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063921#comment-13063921 ]
Chinna Rao Lalam commented on HIVE-2184:
----------------------------------------
Opened Review Board request
https://reviews.apache.org/r/1088/
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067285#comment-13067285 ]
jiraposter@reviews.apache.org commented on HIVE-2184:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1088/#review1099
-----------------------------------------------------------
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
<https://reviews.apache.org/r/1088/#comment2230>
We should get rid of the member variable standAloneClient too since it is part of the dead code.
Now that we'll start calling shutdown (which we were skipping before), what will be the effect?
- John
On 2011-07-12 14:06:28, chinna wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1088/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-12 14:06:28)
bq.
bq.
bq. Review request for hive and John Sichi.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
bq.
bq.
bq. This addresses bug HIVE-2184.
bq. https://issues.apache.org/jira/browse/HIVE-2184
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1144190
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1144190
bq.
bq. Diff: https://reviews.apache.org/r/1088/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran all the testcases
bq.
bq.
bq. Thanks,
bq.
bq. chinna
bq.
bq.
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063916#comment-13063916 ]
jiraposter@reviews.apache.org commented on HIVE-2184:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1088/
-----------------------------------------------------------
Review request for hive and John Sichi.
Summary
-------
Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
This addresses bug HIVE-2184.
https://issues.apache.org/jira/browse/HIVE-2184
Diffs
-----
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1144190
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1144190
Diff: https://reviews.apache.org/r/1088/diff
Testing
-------
Ran all the testcases
Thanks,
chinna
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062389#comment-13062389 ]
Chinna Rao Lalam commented on HIVE-2184:
----------------------------------------
patch is rebased against trunk.
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2184:
-----------------------------------
Attachment: HIVE-2184.3.patch
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.2.patch, HIVE-2184.3.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2184:
-----------------------------------
Attachment: HIVE-2184.1.patch
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086303#comment-13086303 ]
jiraposter@reviews.apache.org commented on HIVE-2184:
-----------------------------------------------------
bq. On 2011-07-18 20:45:26, John Sichi wrote:
bq. > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java, line 267
bq. > <https://reviews.apache.org/r/1088/diff/1/?file=22380#file22380line267>
bq. >
bq. > We should get rid of the member variable standAloneClient too since it is part of the dead code.
bq. >
bq. > Now that we'll start calling shutdown (which we were skipping before), what will be the effect?
bq. >
1) standAloneClient this variable is removed.
2) As of now metaStoreClient.close() is not executing client.shutdown() because of this fix it will close the objectStore. After closing if any get request it will create new objectStore.
- chinna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1088/#review1099
-----------------------------------------------------------
On 2011-07-12 14:06:28, chinna wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1088/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-12 14:06:28)
bq.
bq.
bq. Review request for hive and John Sichi.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
bq.
bq.
bq. This addresses bug HIVE-2184.
bq. https://issues.apache.org/jira/browse/HIVE-2184
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1144190
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1144190
bq.
bq. Diff: https://reviews.apache.org/r/1088/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran all the testcases
bq.
bq.
bq. Thanks,
bq.
bq. chinna
bq.
bq.
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.2.patch, HIVE-2184.3.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2184) Few improvements in
org.apache.hadoop.hive.ql.metadata.Hive.close()
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HIVE-2184:
-----------------------------------
Attachment: HIVE-2184.2.patch
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.2.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira