You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/02/21 03:25:00 UTC

[GitHub] [netbeans] BradWalker opened a new pull request #3651: Update merge

BradWalker opened a new pull request #3651:
URL: https://github.com/apache/netbeans/pull/3651


   I was too aggressive with merging my updates. This merge provides changes that were suggested
   to me by a Netbeans engineer.
   
   
   
   ---
   **^Add meaningful description above**
   
   By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
   
    - are all your own work, and you have the right to contribute them.
    - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
   
   Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
   
   If you're a first time contributor, see the Contributing guidelines for more information.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #3651: Update merge

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3651:
URL: https://github.com/apache/netbeans/pull/3651#issuecomment-1046457141


   @BradWalker no worries, looks good. I would have removed the empty line between the cases but it doesn't really matter
   
   I was more worried about a possible NPE and tried to investigate while you pressed merge at the same time :). But looking at the original code in NB again, vmName can't be null (and if it was it would have caused a NPE before too). False alarm.
   
   Also feel free to aggregate multiple similar changes under one PR in future (if you know in advance that there will be more), this puts less load on the CI cluster (one PR is 2x~2h of cluster time) and also produces less noise in the commit history. 
   NB has a big codebase. Its better to bundle similar cleanup changesets - if reasonably possible (similar discussion here https://github.com/apache/netbeans/pull/3624 - this would have been 20 PRs). And please don't misunderstand, if you only have time for one package - thats perfectly fine, put it into a PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien edited a comment on pull request #3651: Update merge

Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3651:
URL: https://github.com/apache/netbeans/pull/3651#issuecomment-1046457141


   @BradWalker no worries, looks good. I would have removed the empty lines between the cases but it doesn't really matter
   
   I was more worried about a possible NPE and tried to investigate while you pressed merge at the same time :). But looking at the original code in NB again, vmName can't be null (and if it was it would have caused a NPE before too). False alarm.
   
   Also feel free to aggregate multiple similar changes under one PR in future (if you know in advance that there will be more), this puts less load on the CI cluster (one PR is 2x~2h of cluster time) and also produces less noise in the commit history. 
   NB has a big codebase. Its better to bundle similar cleanup changesets - if reasonably possible (similar discussion here https://github.com/apache/netbeans/pull/3624 - this would have been 20 PRs). And please don't misunderstand, if you only have time for one package - thats perfectly fine, put it into a PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] BradWalker commented on pull request #3651: Update merge

Posted by GitBox <gi...@apache.org>.
BradWalker commented on pull request #3651:
URL: https://github.com/apache/netbeans/pull/3651#issuecomment-1046459045


   Thanks @mbien!!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] BradWalker commented on pull request #3651: Update merge

Posted by GitBox <gi...@apache.org>.
BradWalker commented on pull request #3651:
URL: https://github.com/apache/netbeans/pull/3651#issuecomment-1046436556


   Hey @mbien , can you look at this and tell me if it meets with your approval. My apologies for being a little bit aggressive with my previous commit. Two years of removing rust from Netbeans, I was bound to eventually make a mistake. My apologies!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] BradWalker merged pull request #3651: Update merge

Posted by GitBox <gi...@apache.org>.
BradWalker merged pull request #3651:
URL: https://github.com/apache/netbeans/pull/3651


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists