You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/27 17:51:13 UTC

[GitHub] vandanavk opened a new pull request #12686: Remove fixed seed for test_ctc_loss

vandanavk opened a new pull request #12686: Remove fixed seed for test_ctc_loss
URL: https://github.com/apache/incubator-mxnet/pull/12686
 
 
   ## Description ##
   Removed fixed seed for test_ctc_loss and tested for flakiness. Flakiness not observed after 10000 runs.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - Removed fixed seed. Related issue https://github.com/apache/incubator-mxnet/issues/11693
   
   ## Comments ##
   
   ```
   python tools/flakiness_checker.py -n 10000 tests/python/unittest/test_loss.py:test_ctc_loss
   INFO:root:Testing: /Users/kannanva/Documents/mxnet/incubator-mxnet/tests/python/unittest/test_loss.py:test_ctc_loss
   INFO:root:No test seed provided, using random seed
   /Users/kannanva/anaconda3/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
     from ._conv import register_converters as _register_converters
   [INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=1542016506 to reproduce.
   test_loss.test_ctc_loss ... ok
   
   ----------------------------------------------------------------------
   Ran 1 test in 64.487s
   
   OK
   INFO:root:Nosetests terminated with exit code 0
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services