You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2024/04/23 03:44:31 UTC

[I] [C++][CMake] ARROW_NO_DEPRECATED_API is unused? [arrow]

wgtmac opened a new issue, #41343:
URL: https://github.com/apache/arrow/issues/41343

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   When I was reading the CMake code, I found that ARROW_NO_DEPRECATED_API is not used in the source code. Am I missing something?
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][CMake] ARROW_NO_DEPRECATED_API is unused? [arrow]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #41343:
URL: https://github.com/apache/arrow/issues/41343#issuecomment-2071426459

   OK, let me remove this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][CMake] ARROW_NO_DEPRECATED_API is unused [arrow]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac closed issue #41343: [C++][CMake] ARROW_NO_DEPRECATED_API is unused
URL: https://github.com/apache/arrow/issues/41343


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][CMake] ARROW_NO_DEPRECATED_API is unused? [arrow]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #41343:
URL: https://github.com/apache/arrow/issues/41343#issuecomment-2071353098

   cc @kou @pitrou 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][CMake] ARROW_NO_DEPRECATED_API is unused [arrow]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #41343:
URL: https://github.com/apache/arrow/issues/41343#issuecomment-2105545739

   Issue resolved by pull request 41345
   https://github.com/apache/arrow/pull/41345


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][CMake] ARROW_NO_DEPRECATED_API is unused? [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #41343:
URL: https://github.com/apache/arrow/issues/41343#issuecomment-2071409919

   GH-13288 removed the last `#ifndef ARROW_NO_DEPRECATED_API`.
   It seems that we can remove the CMake variable.
   
   We can use `ARROW_DEPRECATED()` and `-Werror=deprecated-declarations` instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org