You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/11 07:13:47 UTC
[GitHub] [spark] ulysses-you opened a new pull request #35490: [SPARK-38185][SQL] Fix data incorrect if aggregate function is empty
ulysses-you opened a new pull request #35490:
URL: https://github.com/apache/spark/pull/35490
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add `aggregateExpressions.nonEmpty` check in `groupOnly` function.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The group only condition should check if the aggregate expression is empty.
In DataFrame api, it is allowed to make a empty aggregations.
So the following query should return 1 rather than 0 because it's a global aggregate.
```scala
val emptyAgg = Map.empty[String, String]
spark.range(2).where("id > 2").agg(emptyAgg).limit(1).count
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes, bug fix
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Add test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #35490: [SPARK-38185][SQL] Fix data incorrect if aggregate function is empty
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35490:
URL: https://github.com/apache/spark/pull/35490#issuecomment-1035944511
cc @sigmod as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35490: [SPARK-38185][SQL] Fix data incorrect if aggregate function is empty
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35490:
URL: https://github.com/apache/spark/pull/35490#issuecomment-1036428549
Could you make a backporting PR for `branch-3.1` please, @ulysses-you ?
```scala
scala> val emptyAgg = Map.empty[String, String]
emptyAgg: scala.collection.immutable.Map[String,String] = Map()
scala> spark.range(2).where("id > 2").agg(emptyAgg).limit(1).count
res0: Long = 1
scala> spark.version
res1: String = 3.1.2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun removed a comment on pull request #35490: [SPARK-38185][SQL] Fix data incorrect if aggregate function is empty
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun removed a comment on pull request #35490:
URL: https://github.com/apache/spark/pull/35490#issuecomment-1036428549
Could you make a backporting PR for `branch-3.1` please, @ulysses-you ?
```scala
scala> val emptyAgg = Map.empty[String, String]
emptyAgg: scala.collection.immutable.Map[String,String] = Map()
scala> spark.range(2).where("id > 2").agg(emptyAgg).limit(1).count
res0: Long = 1
scala> spark.version
res1: String = 3.1.2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #35490: [SPARK-38185][SQL] Fix data incorrect if aggregate function is empty
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35490:
URL: https://github.com/apache/spark/pull/35490#issuecomment-1036201736
thanks, merging to master/3.2!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #35490: [SPARK-38185][SQL] Fix data incorrect if aggregate function is empty
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #35490:
URL: https://github.com/apache/spark/pull/35490#issuecomment-1035935771
cc @wangyum @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #35490: [SPARK-38185][SQL] Fix data incorrect if aggregate function is empty
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #35490:
URL: https://github.com/apache/spark/pull/35490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35490: [SPARK-38185][SQL] Fix data incorrect if aggregate function is empty
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35490:
URL: https://github.com/apache/spark/pull/35490#discussion_r804410010
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -984,7 +984,8 @@ case class Aggregate(
// Whether this Aggregate operator is group only. For example: SELECT a, a FROM t GROUP BY a
private[sql] def groupOnly: Boolean = {
- aggregateExpressions.map {
+ // aggregateExpressions can be empty through Dateset.agg
+ aggregateExpressions.nonEmpty && aggregateExpressions.map {
Review comment:
is it more explicit to check `groupingExpressions.nonEmpty`? Logically, an aggregate operator without output columns is still group only if it has group columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #35490: [SPARK-38185][SQL] Fix data incorrect if aggregate function is empty
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #35490:
URL: https://github.com/apache/spark/pull/35490#discussion_r804421898
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -984,7 +984,8 @@ case class Aggregate(
// Whether this Aggregate operator is group only. For example: SELECT a, a FROM t GROUP BY a
private[sql] def groupOnly: Boolean = {
- aggregateExpressions.map {
+ // aggregateExpressions can be empty through Dateset.agg
+ aggregateExpressions.nonEmpty && aggregateExpressions.map {
Review comment:
make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35490: [SPARK-38185][SQL] Fix data incorrect if aggregate function is empty
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35490:
URL: https://github.com/apache/spark/pull/35490#issuecomment-1036442096
The code looks good but `branch-3.2` seems not to have this issue.
The UT passes without the patch in `branch-3.2`. Do you know what difference causes the issue at master branch, @ulysses-you ?
BTW, I'm good to have this in branch-3.2 in any case because new code looks robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #35490: [SPARK-38185][SQL] Fix data incorrect if aggregate function is empty
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #35490:
URL: https://github.com/apache/spark/pull/35490#issuecomment-1036912931
thank you @dongjoon-hyun , The rule that change aggregate if it's group only with limit 1 to project is landed at branch-3.3 see [SPARK-36183](https://issues.apache.org/jira/browse/SPARK-36183), and it's the key to trigger this bug. But the group only condition is added since branch-3.2, see [SPARK-34808](https://issues.apache.org/jira/browse/SPARK-34808).
So it would be good to also fix this in branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org