You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/02/01 21:58:23 UTC
[GitHub] flink pull request #3251: [FLINK-2908] [web frontend] Redraw web plan when b...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3251
[FLINK-2908] [web frontend] Redraw web plan when browser resized
Redraw the job plan visual graph when the browser width is increased.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 2908_web_interface_redraw_web_plan_when_resized
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3251.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3251
----
commit 085fcac0414f536806e7d9e48454fe457cfee4fd
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-02-01T21:56:03Z
[FLINK-2908] [web frontend] Redraw web plan when browser resized
Redraw the job plan visual graph when the browser width is increased.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3251: [FLINK-2908] [web frontend] Redraw web plan when browser ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3251
Hey Greg, I checked out the PR and still had the behaviour described in the JIRA (checked with Firefox and Chrome). Note that refreshing the page after resizing does also not change anything for me. There is a high chance that my setup is causing this, but is there a way to double check this? Could you maybe post a screenshot of the expected output after resizing the width (w/o refreshing) comparing it to the non-fixed version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3251: [FLINK-2908] [web frontend] Redraw web plan when browser ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3251
Thanks for the screenshots. My job was simple too narrow (not enough operators). After trying with a job that has more operators, I could reproduce the fix. Initially, I though that redrawing meant "zooming in" to fill the preview window.
+1 to merge, great fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3251: [FLINK-2908] [web frontend] Redraw web plan when b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3251
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3251: [FLINK-2908] [web frontend] Redraw web plan when browser ...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3251
@uce thanks for looking at this and my apologies for not including screenshots. I am also using Firefox. An explicit page reload should force page assets to be redownloaded.
Currently switching browser to fullscreen does not resize the job graph SVG:
With this PR the SVG is resized to fill the space:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---