You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "waynexia (via GitHub)" <gi...@apache.org> on 2025/01/14 13:10:42 UTC
[PR] fix: add support for Decimal128 and Decimal256 types in interval arit… [datafusion]
waynexia opened a new pull request, #14126:
URL: https://github.com/apache/datafusion/pull/14126
…hmetic
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/datafusion/issues/14124
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Fixes the panic when decimal computation overflows
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
This patch contains two fixes:
- fix the logic of checking if a value is negative.
- implement `extreme_value` for decimal 128 and 256 types
## Are these changes tested?
*adding test*
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: add support for Decimal128 and Decimal256 types in interval arithmetic [datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1920254738
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDayNano) => {
ScalarValue::IntervalMonthDayNano(Some(IntervalMonthDayNano::$extreme))
}
+ DataType::Decimal128(precision, scale) => {
+ ScalarValue::Decimal128(Some(i128::$extreme), *precision, *scale)
Review Comment:
Ahh, that makes sense. These huge arrays remind me it should be all of `9`s...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: add support for Decimal128 and Decimal256 types in interval arithmetic [datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia merged PR #14126:
URL: https://github.com/apache/datafusion/pull/14126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: add support for Decimal128 and Decimal256 types in interval arithmetic [datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#issuecomment-2613965595
Thank you @comphead and @alamb for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: add support for Decimal128 and Decimal256 types in interval arithmetic [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1920352694
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDayNano) => {
ScalarValue::IntervalMonthDayNano(Some(IntervalMonthDayNano::$extreme))
}
+ DataType::Decimal128(precision, scale) => {
+ ScalarValue::Decimal128(Some(i128::$extreme), *precision, *scale)
Review Comment:
> sadly the decimal 256 version is not public 😢 let me find a workaround
I recommend
1. copy/pasting the value into DataFusion for now
2. File a ticket in arrow-rs to make it public (or maybe even a PR!)
3. leave a comment next to the copy in DataFUsion referencing the upstream ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: add support for Decimal128 and Decimal256 types in interval arithmetic [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1920803813
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDayNano) => {
ScalarValue::IntervalMonthDayNano(Some(IntervalMonthDayNano::$extreme))
}
+ DataType::Decimal128(precision, scale) => {
+ ScalarValue::Decimal128(Some(i128::$extreme), *precision, *scale)
Review Comment:
I filed a PR in arrow to expose these constants:
- https://github.com/apache/arrow-rs/pull/6992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: add support for Decimal128 and Decimal256 types in interval arithmetic [datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1920264150
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDayNano) => {
ScalarValue::IntervalMonthDayNano(Some(IntervalMonthDayNano::$extreme))
}
+ DataType::Decimal128(precision, scale) => {
+ ScalarValue::Decimal128(Some(i128::$extreme), *precision, *scale)
Review Comment:
sadly the decimal 256 version is not public 😢 let me find a workaround
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: add support for Decimal128 and Decimal256 types in interval arithmetic [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#issuecomment-2598600811
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look
I think we just need to tweak the max
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: add support for Decimal128 and Decimal256 types in interval arithmetic [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1916864288
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDayNano) => {
ScalarValue::IntervalMonthDayNano(Some(IntervalMonthDayNano::$extreme))
}
+ DataType::Decimal128(precision, scale) => {
+ ScalarValue::Decimal128(Some(i128::$extreme), *precision, *scale)
Review Comment:
I dug around in arrow a bit and I think these are the min/max values for each decimal precision
https://docs.rs/arrow/latest/arrow/datatypes/constant.MIN_DECIMAL_FOR_EACH_PRECISION.html
https://docs.rs/arrow/latest/arrow/datatypes/constant.MAX_DECIMAL_FOR_EACH_PRECISION.html
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDayNano) => {
ScalarValue::IntervalMonthDayNano(Some(IntervalMonthDayNano::$extreme))
}
+ DataType::Decimal128(precision, scale) => {
+ ScalarValue::Decimal128(Some(i128::$extreme), *precision, *scale)
Review Comment:
Is this correct for min/max of i128? It seems like the minimum value of Decimal128(precision, scale) would be the minimum value for the precision and scale separately rather than the min value of the overall i128 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: add support for Decimal128 and Decimal256 types in interval arithmetic [datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1920271011
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDayNano) => {
ScalarValue::IntervalMonthDayNano(Some(IntervalMonthDayNano::$extreme))
}
+ DataType::Decimal128(precision, scale) => {
+ ScalarValue::Decimal128(Some(i128::$extreme), *precision, *scale)
Review Comment:
maybe `get_extreme_value` should be part of arrow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: add support for Decimal128 and Decimal256 types in interval arithmetic [datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#issuecomment-2610062530
Hi @alamb, I've copied constant vectors from arrow, please take another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: add support for Decimal128 and Decimal256 types in interval arithmetic [datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#issuecomment-2591632023
> thanks @waynexia I feed we can also add the initial problematic query into `.slt` file?
>
> ```
> SELECT ('0.54321543215432154321543215432154321'::DECIMAL(35,35) + 10000)::VARCHAR
> ```
Done :+1:, added one in `select.slt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org