You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/08/17 06:11:39 UTC

Review Request 37515: DRILL-3657: Wrong result with SUM(1) window function when multiple partitions are present

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37515/
-----------------------------------------------------------

Review request for drill and Aman Sinha.


Bugs: DRILL-3657
    https://issues.apache.org/jira/browse/DRILL-3657


Repository: drill-git


Description
-------

When constants are referred in Window Prel, ensure the indices are shifted properly


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java f6d2b67 
  exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 9e09106 

Diff: https://reviews.apache.org/r/37515/diff/


Testing
-------

All required


Thanks,

Sean Hsuan-Yi Chu


Re: Review Request 37515: DRILL-3657: Wrong result with SUM(1) window function when multiple partitions are present

Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.

> On Aug. 17, 2015, 4:08 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java, line 159
> > <https://reviews.apache.org/r/37515/diff/1/?file=1041599#file1041599line159>
> >
> >     Would this work if there was non-window-agg functions present...such as RANK() (in combination with window aggs) ?

Rank works too. Also, I modified the unit test to have more general coverage there.


- Sean Hsuan-Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37515/#review95592
-----------------------------------------------------------


On Aug. 17, 2015, 4:11 a.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37515/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 4:11 a.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-3657
>     https://issues.apache.org/jira/browse/DRILL-3657
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> When constants are referred in Window Prel, ensure the indices are shifted properly
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java f6d2b67 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 9e09106 
> 
> Diff: https://reviews.apache.org/r/37515/diff/
> 
> 
> Testing
> -------
> 
> All required
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Re: Review Request 37515: DRILL-3657: Wrong result with SUM(1) window function when multiple partitions are present

Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37515/#review95592
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java (line 158)
<https://reviews.apache.org/r/37515/#comment150628>

    Would this work if there was non-window-agg functions present...such as RANK() (in combination with window aggs) ?


- Aman Sinha


On Aug. 17, 2015, 4:11 a.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37515/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 4:11 a.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-3657
>     https://issues.apache.org/jira/browse/DRILL-3657
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> When constants are referred in Window Prel, ensure the indices are shifted properly
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java f6d2b67 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 9e09106 
> 
> Diff: https://reviews.apache.org/r/37515/diff/
> 
> 
> Testing
> -------
> 
> All required
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Re: Review Request 37515: DRILL-3657: Wrong result with SUM(1) window function when multiple partitions are present

Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37515/#review96011
-----------------------------------------------------------

Ship it!


Ship It!

- Aman Sinha


On Aug. 17, 2015, 4:54 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37515/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 4:54 p.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-3657
>     https://issues.apache.org/jira/browse/DRILL-3657
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> When constants are referred in Window Prel, ensure the indices are shifted properly
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java f6d2b67 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 9e09106 
> 
> Diff: https://reviews.apache.org/r/37515/diff/
> 
> 
> Testing
> -------
> 
> All required
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Re: Review Request 37515: DRILL-3657: Wrong result with SUM(1) window function when multiple partitions are present

Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37515/
-----------------------------------------------------------

(Updated Aug. 17, 2015, 4:54 p.m.)


Review request for drill and Aman Sinha.


Changes
-------

Modified unit test


Bugs: DRILL-3657
    https://issues.apache.org/jira/browse/DRILL-3657


Repository: drill-git


Description
-------

When constants are referred in Window Prel, ensure the indices are shifted properly


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java f6d2b67 
  exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 9e09106 

Diff: https://reviews.apache.org/r/37515/diff/


Testing
-------

All required


Thanks,

Sean Hsuan-Yi Chu