[jira] [Commented] (SPARK-23960) Mark HashAggregateExec.bufVars as transient

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-23960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433672#comment-16433672 ] 

Apache Spark commented on SPARK-23960:
--------------------------------------

User 'rednaxelafx' has created a pull request for this issue:
https://github.com/apache/spark/pull/21039

> Mark HashAggregateExec.bufVars as transient
> -------------------------------------------
>
>                 Key: SPARK-23960
>                 URL: https://issues.apache.org/jira/browse/SPARK-23960
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 2.3.0
>            Reporter: Kris Mok
>            Priority: Minor
>
> {{HashAggregateExec.bufVars}} is only used during codegen for global aggregation. Specifically it's only used while {{doProduceWithoutKeys()}} is on the stack.
> Currently, if an {{HashAggregateExec}} is ever captured for serialization, the {{bufVars}} would be needlessly serialized.
> This ticket proposes a minor change to mark the {{bufVars}} field as transient to avoid serializing it. Also, null out this field at the end of {{doProduceWithoutKeys()}} to reduce its lifecycle so that the {{Seq[ExprCode]}} being referenced can be GC'd sooner.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org