You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/07/15 12:31:18 UTC
[GitHub] [jena] afs opened a new pull request, #1445: GH-1440: Fuseki/webapp. Command line argument processing.
afs opened a new pull request, #1445:
URL: https://github.com/apache/jena/pull/1445
GitHub issue resolved #1440.
Pull request Description:
* Fix for #1440
Read-only access when publishing a dataset.
* Convert creations template to new style endpoint descriptions.
* Generalize template processing : existing templates still work.
* Review command line argument processing and organise logically.
----
- [x] Tests are included.
- [x] Commits have been squashed to remove intermediate development commit messages.
- [x] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1445: GH-1440: Fuseki/webapp. Command line argument processing.
Posted by GitBox <gi...@apache.org>.
afs merged PR #1445:
URL: https://github.com/apache/jena/pull/1445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a diff in pull request #1445: GH-1440: Fuseki/webapp. Command line argument processing.
Posted by GitBox <gi...@apache.org>.
kinow commented on code in PR #1445:
URL: https://github.com/apache/jena/pull/1445#discussion_r922554541
##########
jena-fuseki2/jena-fuseki-webapp/src/main/java/org/apache/jena/fuseki/cmd/FusekiCmd.java:
##########
@@ -138,6 +131,11 @@ public FusekiCmdInner(String... argv) {
"Use an existing TDB database (or create if does not exist)");
add(argMemTDB, "--memTDB",
"Create an in-memory, non-persistent dataset using TDB (testing only)");
+
+ // This is has proven confusing because it is like --conf.
Review Comment:
s/This is has/This has/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1445: GH-1440: Fuseki/webapp. Command line argument processing.
Posted by GitBox <gi...@apache.org>.
afs commented on code in PR #1445:
URL: https://github.com/apache/jena/pull/1445#discussion_r922664556
##########
jena-fuseki2/jena-fuseki-webapp/src/main/java/org/apache/jena/fuseki/cmd/FusekiCmd.java:
##########
@@ -138,6 +131,11 @@ public FusekiCmdInner(String... argv) {
"Use an existing TDB database (or create if does not exist)");
add(argMemTDB, "--memTDB",
"Create an in-memory, non-persistent dataset using TDB (testing only)");
+
+ // This is has proven confusing because it is like --conf.
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org