[GitHub] [incubator-doris] lingbin commented on a change in pull request #2933: Use `std::bind` to replace `boost::bind` in flush-executor

[GitBox <gi...@apache.org>]

lingbin commented on a change in pull request #2933: Use `std::bind` to replace `boost::bind` in flush-executor
URL: https://github.com/apache/incubator-doris/pull/2933#discussion_r380753659
 
 

 ##########
 File path: be/src/olap/memtable_flush_executor.cpp
 ##########
 @@ -35,15 +31,15 @@ std::ostream& operator<<(std::ostream& os, const FlushStatistic& stat) {
 }
 
 OLAPStatus FlushToken::submit(std::shared_ptr<MemTable> memtable) {
 
 Review comment:
   After the `submit()` returns, the upper layer will immediately reset the `memtable` (let it be `nullptr`), and the lower thread pool may not yet start processing it. If a reference is used, when the thread pool starts to process this `memtable`, the corresponding object may have become invalid.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org