You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/08/14 07:54:01 UTC

Review Request 71287: Added a test `SlaveTest.DefaultExecutorResources`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71287/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-9925
    https://issues.apache.org/jira/browse/MESOS-9925


Repository: mesos


Description
-------

Added a test `SlaveTest.DefaultExecutorResources`.


Diffs
-----

  src/tests/slave_tests.cpp 1a926029a9f81eb0c43e9cddd73c318557760c27 


Diff: https://reviews.apache.org/r/71287/diff/1/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Re: Review Request 71287: Added a test `SlaveTest.DefaultExecutorResources`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71287/#review217231
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Aug. 14, 2019, 12:54 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71287/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2019, 12:54 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9925
>     https://issues.apache.org/jira/browse/MESOS-9925
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `SlaveTest.DefaultExecutorResources`.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 1a926029a9f81eb0c43e9cddd73c318557760c27 
> 
> 
> Diff: https://reviews.apache.org/r/71287/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 71287: Added a test `SlaveTest.DefaultExecutorResources`.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71287/#review217207
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71244, 71287]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 14, 2019, 12:54 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71287/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2019, 12:54 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9925
>     https://issues.apache.org/jira/browse/MESOS-9925
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `SlaveTest.DefaultExecutorResources`.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 1a926029a9f81eb0c43e9cddd73c318557760c27 
> 
> 
> Diff: https://reviews.apache.org/r/71287/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>