You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/21 11:07:17 UTC

[GitHub] [dubbo-go-hessian2] hxmhlt commented on a change in pull request #250: fix lint error

hxmhlt commented on a change in pull request #250:
URL: https://github.com/apache/dubbo-go-hessian2/pull/250#discussion_r546645007



##########
File path: list.go
##########
@@ -305,7 +305,7 @@ func (d *Decoder) readTypedList(tag byte) (interface{}, error) {
 
 	isVariableArr := tag == BC_LIST_VARIABLE
 
-	length := -1
+	var length int
 	if listFixedTypedLenTag(tag) {

Review comment:
       这个改动会影响下面的使用,确定是对的吗Line 323 Line325

##########
File path: date.go
##########
@@ -40,8 +40,7 @@ func encDateInMs(b []byte, i interface{}) []byte {
 	value := UnpackPtrValue(reflect.ValueOf(i))
 	vi := value.Interface().(time.Time)
 	if vi == ZeroDate {
-		b = append(b, BC_NULL)
-		return nil
+		return append(b, BC_NULL)
 	}

Review comment:
       The return result is changed.  Is it right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org