You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@yetus.apache.org by GitBox <gi...@apache.org> on 2022/06/03 08:45:50 UTC
[GitHub] [yetus] giggsoff opened a new pull request, #284: Add uniq-by-line option to golangci
giggsoff opened a new pull request, #284:
URL: https://github.com/apache/yetus/pull/284
In order to have all complains in results of golangci we should set
uniq-by-line to false. Having uniq-by-line equals true (default) force
golangci to output only the first error per line comes from linters in
random order. Random errors give us unpredictable diff between branch
and patch results.
Signed-off-by: Petr Fedchenkov <gi...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] giggsoff commented on pull request #284: YETUS-1191. Add uniq-by-line option to golangci
Posted by GitBox <gi...@apache.org>.
giggsoff commented on PR #284:
URL: https://github.com/apache/yetus/pull/284#issuecomment-1177893794
> @giggsoff do you have an account on [Apache JIRA](https://issues.apache.org/jira) that I can assign https://issues.apache.org/jira/browse/YETUS-1191 to you? Thanks for the contribution!
I signed up and commented on issue there. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #284: Add uniq-by-line option to golangci
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on PR #284:
URL: https://github.com/apache/yetus/pull/284#issuecomment-1177786568
@giggsoff do you have an account on [Apache JIRA](https://issues.apache.org/jira) that I can assign https://issues.apache.org/jira/browse/YETUS-1191 to you? Thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #284: YETUS-1191. Add uniq-by-line option to golangci
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on PR #284:
URL: https://github.com/apache/yetus/pull/284#issuecomment-1178209822
Thanks @giggsoff !
+1 Merging into main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here merged pull request #284: YETUS-1191. Add uniq-by-line option to golangci
Posted by GitBox <gi...@apache.org>.
aw-was-here merged PR #284:
URL: https://github.com/apache/yetus/pull/284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org