You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/06 16:24:45 UTC
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz opened a new issue #604:
Remove fake status bar for iOS
NiklasMerz opened a new issue #604: Remove fake status bar for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/604
There are some issues with iPhones with a notch and the status bar. PR #546 tries to fix that by removing the status bar for these devices.
This is not a proper fix, it just hides the fake status bar for iPhone X and other devices with notches.
The proper fix should make the fake statusbar the size of the notch to be consistent, or just remove the fake statusbar for all devices.
_Originally posted by @jcesarmobile in https://github.com/apache/cordova-plugin-inappbrowser/pull/546#issuecomment-542434369_
Discussion in #546 tends to the removal of the status bar in major release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on issue #604:
Remove fake status bar for iOS
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on issue #604: Remove fake status bar for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/604#issuecomment-599046405
This has nothing to do with this issue. A version which removes the statusbar does not exist, yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on issue #604:
Remove fake status bar for iOS
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on issue #604: Remove fake status bar for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/604#issuecomment-572223412
We should try to get a consistent behaviour with Android. See #598
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] sardapv edited a comment on issue
#604: Remove fake status bar for iOS
Posted by GitBox <gi...@apache.org>.
sardapv edited a comment on issue #604: Remove fake status bar for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/604#issuecomment-609738589
I have fixed that notch issue for iphoneX+ series (https://issues.apache.org/jira/browse/CB-13956)
It handles both landscape and portrait orientation change as well (right left area both). Inappbrowser scales first checking all other factors. Only problem I found is when I change to landscape mode I see status bar pane but no battery wifi or any symbol in it. Not a major issue I suppose. Currently those changes are on my local.
@jcesarmobile @NiklasMerz
It does similar thing that is in PR https://github.com/apache/cordova-plugin-inappbrowser/pull/546
But does it better with orientation change even afterIAB is opened. Also handles right left safe area. Doesn't remove status bar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] benvallack commented on issue #604:
Remove fake status bar for iOS
Posted by GitBox <gi...@apache.org>.
benvallack commented on issue #604: Remove fake status bar for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/604#issuecomment-598699665
So how do we use this version? Also if we use _self to get the pages to load in the cordova view itself, would that improve things? Trouble is I see this issue when I try that: https://stackoverflow.com/questions/58321114/why-i-get-the-console-warning-process-kill-returned-unexpected-error-1-when
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] sardapv commented on issue #604:
Remove fake status bar for iOS
Posted by GitBox <gi...@apache.org>.
sardapv commented on issue #604: Remove fake status bar for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/604#issuecomment-609738589
I have fixed that notch issue for iphoneX+ series (https://issues.apache.org/jira/browse/CB-13956)
It handles both landscape and portrait orientation change as well (right left area both). Inappbrowser scales first checking all other factors. Only problem I found is when I change to landscape mode I see status bar pane but no battery wifi or any symbol in it. Not a major issue I suppose. Currently those changes are on my local.
@jcesarmobile @NiklasMerz
It does similar thing that is in PR https://github.com/apache/cordova-plugin-inappbrowser/pull/546
But does it better with orientation change even afterIAB is opened.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] ashtt commented on issue #604: Remove
fake status bar for iOS
Posted by GitBox <gi...@apache.org>.
ashtt commented on issue #604: Remove fake status bar for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/604#issuecomment-587107400
Around what time/month or in which version should we expect this fix ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile commented on issue #604:
Remove fake status bar for iOS
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on issue #604: Remove fake status bar for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/604#issuecomment-587108778
When somebody sends a pull requests that fixes it and it gets merged and a release process is started and finish successfully.
Version >= 4.0.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org