You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2014/01/24 12:37:47 UTC

svn commit: r1560946 - in /lucene/dev/branches/lucene5376/lucene: replicator/src/java/org/apache/lucene/replicator/ replicator/src/java/org/apache/lucene/replicator/http/ server/src/java/org/apache/lucene/server/handlers/

Author: mikemccand
Date: Fri Jan 24 11:37:46 2014
New Revision: 1560946

URL: http://svn.apache.org/r1560946
Log:
LUCENE-5376: improve comments / nocommits

Modified:
    lucene/dev/branches/lucene5376/lucene/replicator/src/java/org/apache/lucene/replicator/Replicator.java
    lucene/dev/branches/lucene5376/lucene/replicator/src/java/org/apache/lucene/replicator/http/ReplicationService.java
    lucene/dev/branches/lucene5376/lucene/server/src/java/org/apache/lucene/server/handlers/RegisterFieldHandler.java

Modified: lucene/dev/branches/lucene5376/lucene/replicator/src/java/org/apache/lucene/replicator/Replicator.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene5376/lucene/replicator/src/java/org/apache/lucene/replicator/Replicator.java?rev=1560946&r1=1560945&r2=1560946&view=diff
==============================================================================
--- lucene/dev/branches/lucene5376/lucene/replicator/src/java/org/apache/lucene/replicator/Replicator.java (original)
+++ lucene/dev/branches/lucene5376/lucene/replicator/src/java/org/apache/lucene/replicator/Replicator.java Fri Jan 24 11:37:46 2014
@@ -33,7 +33,7 @@ import java.io.InputStream;
  * <p>
  * A client is always updated to the newest revision available. That is, if a
  * client is on revision <em>r1</em> and revisions <em>r2</em> and <em>r3</em>
- * were published, then when the cllient will next check for update, it will
+ * were published, then when the client will next check for update, it will
  * receive <em>r3</em>.
  * 
  * @lucene.experimental

Modified: lucene/dev/branches/lucene5376/lucene/replicator/src/java/org/apache/lucene/replicator/http/ReplicationService.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene5376/lucene/replicator/src/java/org/apache/lucene/replicator/http/ReplicationService.java?rev=1560946&r1=1560945&r2=1560946&view=diff
==============================================================================
--- lucene/dev/branches/lucene5376/lucene/replicator/src/java/org/apache/lucene/replicator/http/ReplicationService.java (original)
+++ lucene/dev/branches/lucene5376/lucene/replicator/src/java/org/apache/lucene/replicator/http/ReplicationService.java Fri Jan 24 11:37:46 2014
@@ -172,7 +172,7 @@ public class ReplicationService {
           if (token == null) {
             resOut.write(0); // marker for null token
           } else {
-            resOut.write(1); // marker for null token
+            resOut.write(1); // marker for non-null token
             token.serialize(new DataOutputStream(resOut));
           }
           break;

Modified: lucene/dev/branches/lucene5376/lucene/server/src/java/org/apache/lucene/server/handlers/RegisterFieldHandler.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene5376/lucene/server/src/java/org/apache/lucene/server/handlers/RegisterFieldHandler.java?rev=1560946&r1=1560945&r2=1560946&view=diff
==============================================================================
--- lucene/dev/branches/lucene5376/lucene/server/src/java/org/apache/lucene/server/handlers/RegisterFieldHandler.java (original)
+++ lucene/dev/branches/lucene5376/lucene/server/src/java/org/apache/lucene/server/handlers/RegisterFieldHandler.java Fri Jan 24 11:37:46 2014
@@ -792,7 +792,10 @@ public class RegisterFieldHandler extend
     };
   }
 
-  // nocommit can we use SynonmyFilterFactory???
+  // nocommit can we use SynonmyFilterFactory???  we could
+  // make a custom Reader subclass that sneaks the
+  // JSONObject "through", and then a custom
+  // SynFilter.Parser that grabs that JSONObject?
 
   static TokenFilterFactory buildSynonymFilterFactory(IndexState state, Request r) throws IOException {