You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2012/07/16 11:44:33 UTC
[jira] [Created] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed in strict mode
Namit Jain created HIVE-3261:
--------------------------------
Summary: alter the number of buckets for a non-empty partitioned table should not be allowed in strict mode
Key: HIVE-3261
URL: https://issues.apache.org/jira/browse/HIVE-3261
Project: Hive
Issue Type: Bug
Reporter: Namit Jain
Assignee: Namit Jain
This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421062#comment-13421062 ]
Hudson commented on HIVE-3261:
------------------------------
Integrated in Hive-trunk-h0.21 #1562 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1562/])
HIVE-3261. alter the number of buckets for a non-empty partitioned table should not be allowed. (njain via kevinwilfong) (Revision 1364815)
Result = FAILURE
kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1364815
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
* /hive/trunk/ql/src/test/queries/clientnegative/alter_numbuckets_partitioned_table.q
* /hive/trunk/ql/src/test/queries/clientpositive/bucket_groupby.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_04_evolved_parts.q
* /hive/trunk/ql/src/test/results/clientnegative/alter_numbuckets_partitioned_table.q.out
* /hive/trunk/ql/src/test/results/clientpositive/bucket_groupby.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_04_evolved_parts.q.out
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Labels: bucketing
> Fix For: 0.10.0
>
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418914#comment-13418914 ]
Namit Jain commented on HIVE-3261:
----------------------------------
comments addressed
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Labels: bucketing
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419997#comment-13419997 ]
Namit Jain commented on HIVE-3261:
----------------------------------
The tests have been fixed
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Labels: bucketing
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3261:
-----------------------------
Summary: alter the number of buckets for a non-empty partitioned table should not be allowed (was: alter the number of buckets for a non-empty partitioned table should not be allowed in strict mode)
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3261:
-----------------------------
Status: Patch Available (was: Open)
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Labels: bucketing
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3261:
--------------------------------
Status: Open (was: Patch Available)
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Labels: bucketing
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419706#comment-13419706 ]
Kevin Wilfong commented on HIVE-3261:
-------------------------------------
Saw some test failures, e.g. TestCliDriver bucket_groupby.q
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Labels: bucketing
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3261:
---------------------------------
Component/s: Query Processor
Labels: bucketing (was: )
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Labels: bucketing
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3261:
---------------------------------
Status: Open (was: Patch Available)
@Namit: I also added a small comment on phabricator. Thanks.
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418550#comment-13418550 ]
Kevin Wilfong commented on HIVE-3261:
-------------------------------------
This seems ok for now, but could you file a follow up task to use partition metadata instead of table metadata wherever bucketing information is used, and mention that the error message added by this JIRA can be removed once that is done.
One small comment on the diff.
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415014#comment-13415014 ]
Namit Jain commented on HIVE-3261:
----------------------------------
https://reviews.facebook.net/D4143
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3261:
-----------------------------
Status: Patch Available (was: Open)
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Labels: bucketing
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419348#comment-13419348 ]
Kevin Wilfong commented on HIVE-3261:
-------------------------------------
+1 running tests
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Labels: bucketing
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3261:
--------------------------------
Resolution: Fixed
Fix Version/s: 0.10.0
Status: Resolved (was: Patch Available)
Committed, thanks Namit.
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Labels: bucketing
> Fix For: 0.10.0
>
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3261) alter the number of buckets for a
non-empty partitioned table should not be allowed
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3261:
-----------------------------
Status: Patch Available (was: Open)
> alter the number of buckets for a non-empty partitioned table should not be allowed
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3261
> URL: https://issues.apache.org/jira/browse/HIVE-3261
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> This is dangerous since the code uses the table metadata everywhere to get the number of buckets
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira