You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/19 03:26:59 UTC
Review Request 38519: Change function quiesce() to suppressRes()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38519/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
The reason that I was not using suppress() is because suppress is
already defined in
3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
Diffs
-----
src/master/http.cpp 7cca8b1d3118fe99de79cfaf5360825012d830da
src/master/master.hpp 6805177d7c03b701708e1d217a7bc0ac7c79889e
src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27
Diff: https://reviews.apache.org/r/38519/diff/
Testing
-------
Platform: Ubuntu:14.04
make
make check
Thanks,
Guangya Liu
Re: Review Request 38519: Change function quiesce() to suppressRes()
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38519/#review99655
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38514, 38516, 38519]
All tests passed.
- Mesos ReviewBot
On Sept. 19, 2015, 1:26 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38519/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 1:26 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The reason that I was not using suppress() is because suppress is
> already defined in
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
>
>
> Diffs
> -----
>
> src/master/http.cpp 7cca8b1d3118fe99de79cfaf5360825012d830da
> src/master/master.hpp 6805177d7c03b701708e1d217a7bc0ac7c79889e
> src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27
>
> Diff: https://reviews.apache.org/r/38519/diff/
>
>
> Testing
> -------
>
> Platform: Ubuntu:14.04
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 38519: Change function quiesce() to suppress()
Posted by Vinod Kone <vi...@gmail.com>.
> On Sept. 21, 2015, 6:15 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 486
> > <https://reviews.apache.org/r/38519/diff/2/?file=1077903#file1077903line486>
> >
> > doesn't look you changed this to 'suppress' from 'suppressRes'?
i'll fix this for you and commit the chain.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38519/#review99797
-----------------------------------------------------------
On Sept. 21, 2015, 6:06 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38519/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 6:06 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Change function quiesce() to suppress()
>
>
> Diffs
> -----
>
> src/master/http.cpp 607d8e1b6efe0115b09be0a0c73edbd8e64d8415
> src/master/master.hpp 0c1e81cb807ab04e3d836272c0a197362d811d4c
> src/master/master.cpp 6c0db210747c7d88179556abaade65743bd8cb3a
>
> Diff: https://reviews.apache.org/r/38519/diff/
>
>
> Testing
> -------
>
> Platform: Ubuntu:14.04
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 38519: Change function quiesce() to suppress()
Posted by Guangya Liu <gy...@gmail.com>.
> On 九月 21, 2015, 6:15 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 486
> > <https://reviews.apache.org/r/38519/diff/2/?file=1077903#file1077903line486>
> >
> > doesn't look you changed this to 'suppress' from 'suppressRes'?
>
> Vinod Kone wrote:
> i'll fix this for you and commit the chain.
Thanks Vinod for the update, it seems I made some mistake when rebase the code.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38519/#review99797
-----------------------------------------------------------
On 九月 21, 2015, 6:06 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38519/
> -----------------------------------------------------------
>
> (Updated 九月 21, 2015, 6:06 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Change function quiesce() to suppress()
>
>
> Diffs
> -----
>
> src/master/http.cpp 607d8e1b6efe0115b09be0a0c73edbd8e64d8415
> src/master/master.hpp 0c1e81cb807ab04e3d836272c0a197362d811d4c
> src/master/master.cpp 6c0db210747c7d88179556abaade65743bd8cb3a
>
> Diff: https://reviews.apache.org/r/38519/diff/
>
>
> Testing
> -------
>
> Platform: Ubuntu:14.04
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 38519: Change function quiesce() to suppress()
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38519/#review99797
-----------------------------------------------------------
src/master/http.cpp (line 486)
<https://reviews.apache.org/r/38519/#comment156765>
doesn't look you changed this to 'suppress' from 'suppressRes'?
- Vinod Kone
On Sept. 21, 2015, 6:06 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38519/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 6:06 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Change function quiesce() to suppress()
>
>
> Diffs
> -----
>
> src/master/http.cpp 607d8e1b6efe0115b09be0a0c73edbd8e64d8415
> src/master/master.hpp 0c1e81cb807ab04e3d836272c0a197362d811d4c
> src/master/master.cpp 6c0db210747c7d88179556abaade65743bd8cb3a
>
> Diff: https://reviews.apache.org/r/38519/diff/
>
>
> Testing
> -------
>
> Platform: Ubuntu:14.04
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 38519: Change function quiesce() to suppress()
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38519/#review99730
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38514, 38516, 38544, 38519]
All tests passed.
- Mesos ReviewBot
On Sept. 21, 2015, 6:06 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38519/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 6:06 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Change function quiesce() to suppress()
>
>
> Diffs
> -----
>
> src/master/http.cpp 607d8e1b6efe0115b09be0a0c73edbd8e64d8415
> src/master/master.hpp 0c1e81cb807ab04e3d836272c0a197362d811d4c
> src/master/master.cpp 6c0db210747c7d88179556abaade65743bd8cb3a
>
> Diff: https://reviews.apache.org/r/38519/diff/
>
>
> Testing
> -------
>
> Platform: Ubuntu:14.04
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 38519: Change function quiesce() to suppress()
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38519/
-----------------------------------------------------------
(Updated 九月 21, 2015, 6:06 a.m.)
Review request for mesos and Vinod Kone.
Summary (updated)
-----------------
Change function quiesce() to suppress()
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description (updated)
-------
Change function quiesce() to suppress()
Diffs (updated)
-----
src/master/http.cpp 607d8e1b6efe0115b09be0a0c73edbd8e64d8415
src/master/master.hpp 0c1e81cb807ab04e3d836272c0a197362d811d4c
src/master/master.cpp 6c0db210747c7d88179556abaade65743bd8cb3a
Diff: https://reviews.apache.org/r/38519/diff/
Testing
-------
Platform: Ubuntu:14.04
make
make check
Thanks,
Guangya Liu
Re: Review Request 38519: Change function quiesce() to suppressRes()
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38519/#review99718
-----------------------------------------------------------
src/master/http.cpp (line 486)
<https://reviews.apache.org/r/38519/#comment156700>
'suppressRes' is weird. this got to be 'suppress'. we need to figure out how to resolve the conflict with the macro.
- Vinod Kone
On Sept. 19, 2015, 1:26 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38519/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 1:26 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The reason that I was not using suppress() is because suppress is
> already defined in
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
>
>
> Diffs
> -----
>
> src/master/http.cpp 7cca8b1d3118fe99de79cfaf5360825012d830da
> src/master/master.hpp 6805177d7c03b701708e1d217a7bc0ac7c79889e
> src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27
>
> Diff: https://reviews.apache.org/r/38519/diff/
>
>
> Testing
> -------
>
> Platform: Ubuntu:14.04
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>