[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4743: Simplify parquet filter predicate test, fix Page Filtering Incorrectly Handles Pages with Different Row Counts

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #4743:
URL: https://github.com/apache/arrow-datafusion/pull/4743#discussion_r1058501323


##########
datafusion/core/tests/parquet/page_pruning.rs:
##########
@@ -108,14 +108,16 @@ async fn page_index_filter_one_col() {
 
     let batch = results.next().await.unwrap().unwrap();
 
-    // `month = 12` from the page index should create below RowSelection
-    //  vec.push(RowSelector::skip(894));
-    //  vec.push(RowSelector::select(339));
-    //  vec.push(RowSelector::skip(3330));
+    // `month = 1` or `month = 2` from the page index should create below RowSelection

Review Comment:
   These tests were just wrong, I have fixed them using https://github.com/apache/arrow-rs/pull/3405 to verify that they are correct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org