You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/20 03:48:11 UTC

[GitHub] [arrow] rodrigojdebem commented on a change in pull request #9750: ARROW-12021: [C++][Gandiva] Implement to_char() function on Gandiva

rodrigojdebem commented on a change in pull request #9750:
URL: https://github.com/apache/arrow/pull/9750#discussion_r616322266



##########
File path: cpp/src/gandiva/gdv_function_stubs_test.cc
##########
@@ -160,4 +160,118 @@ TEST(TestGdvFnStubs, TestCastFloat8) {
   ctx.Reset();
 }
 
+    TEST(TestGdvFnStubs, TestToCharFromInt32) {
+        gandiva::ExecutionContext ctx;
+        uint64_t ctx_ptr = reinterpret_cast<int64_t>(&ctx);
+        int32_t out_len = 0;
+
+        const char* out_str = gdv_fn_to_char_int32_int64(ctx_ptr, -46, 100, "%1", &out_len);

Review comment:
       The implementation is aiming to use the Java formatting.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org