You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/08/03 16:57:17 UTC
[jira] Created: (CASSANDRA-1350) DynamicEndpointSnitch is defeated
by the caching done in Strategy
DynamicEndpointSnitch is defeated by the caching done in Strategy
-----------------------------------------------------------------
Key: CASSANDRA-1350
URL: https://issues.apache.org/jira/browse/CASSANDRA-1350
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.7 beta 1
Reporter: Jonathan Ellis
Fix For: 0.7 beta 1
can we move the caching into AbstractEndpointSnitch instead?
also: AES.register appears to never be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1350) DynamicEndpointSnitch is
defeated by the caching done in Strategy
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898583#action_12898583 ]
Hudson commented on CASSANDRA-1350:
-----------------------------------
Integrated in Cassandra #514 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/514/])
move endpoint cache from ARS to AES. patch by gdusbabek, reviewed by jbellis. CASSANDRA-1350
> DynamicEndpointSnitch is defeated by the caching done in Strategy
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1350
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1350
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Gary Dusbabek
> Fix For: 0.7 beta 2
>
> Attachments: 0001-move-endpoint-cache-from-ARS-to-AES.patch
>
>
> can we move the caching into AbstractEndpointSnitch instead?
> also: AES.register appears to never be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1350) DynamicEndpointSnitch is
defeated by the caching done in Strategy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897758#action_12897758 ]
Jonathan Ellis commented on CASSANDRA-1350:
-------------------------------------------
+1 Gary's patch
> DynamicEndpointSnitch is defeated by the caching done in Strategy
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1350
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1350
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Gary Dusbabek
> Fix For: 0.7 beta 1
>
> Attachments: 0001-move-endpoint-cache-from-ARS-to-AES.patch
>
>
> can we move the caching into AbstractEndpointSnitch instead?
> also: AES.register appears to never be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1350) DynamicEndpointSnitch is
defeated by the caching done in Strategy
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896572#action_12896572 ]
Gary Dusbabek commented on CASSANDRA-1350:
------------------------------------------
Their latencies are cleared, but the scores and windows are never removed. It's a minor point, but updateScores() could be a little more efficient if it didn't have to consider decommissioned nodes.
> DynamicEndpointSnitch is defeated by the caching done in Strategy
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1350
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1350
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Gary Dusbabek
> Fix For: 0.7 beta 1
>
> Attachments: 0001-move-endpoint-cache-from-ARS-to-AES.patch
>
>
> can we move the caching into AbstractEndpointSnitch instead?
> also: AES.register appears to never be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1350) DynamicEndpointSnitch is
defeated by the caching done in Strategy
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897345#action_12897345 ]
Brandon Williams commented on CASSANDRA-1350:
---------------------------------------------
The latencies being cleared is the most important part. At the next interval, if no more latency data is received for that node, updateScores() going to calculate a score for an empty deque, which means the score() function is just to going to do a size check and return 0, which is pretty cheap, so I'm not sure it's worth the extra complexity of notifying the snitch about decommissioned nodes.
> DynamicEndpointSnitch is defeated by the caching done in Strategy
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1350
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1350
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Gary Dusbabek
> Fix For: 0.7 beta 1
>
> Attachments: 0001-move-endpoint-cache-from-ARS-to-AES.patch
>
>
> can we move the caching into AbstractEndpointSnitch instead?
> also: AES.register appears to never be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1350) DynamicEndpointSnitch is defeated
by the caching done in Strategy
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Dusbabek updated CASSANDRA-1350:
-------------------------------------
Attachment: 0001-move-endpoint-cache-from-ARS-to-AES.patch
> DynamicEndpointSnitch is defeated by the caching done in Strategy
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1350
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1350
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Gary Dusbabek
> Fix For: 0.7 beta 1
>
> Attachments: 0001-move-endpoint-cache-from-ARS-to-AES.patch
>
>
> can we move the caching into AbstractEndpointSnitch instead?
> also: AES.register appears to never be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1350) DynamicEndpointSnitch is
defeated by the caching done in Strategy
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895750#action_12895750 ]
Gary Dusbabek commented on CASSANDRA-1350:
------------------------------------------
I noticed that DynamicEndpointSnitch doesn't worry much about invalidating windows (and scores) from nodes that are decommissioned. Is that on purpose?
> DynamicEndpointSnitch is defeated by the caching done in Strategy
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1350
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1350
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Gary Dusbabek
> Fix For: 0.7 beta 1
>
> Attachments: 0001-move-endpoint-cache-from-ARS-to-AES.patch
>
>
> can we move the caching into AbstractEndpointSnitch instead?
> also: AES.register appears to never be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1350) DynamicEndpointSnitch is defeated
by the caching done in Strategy
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Dusbabek reassigned CASSANDRA-1350:
----------------------------------------
Assignee: Gary Dusbabek
> DynamicEndpointSnitch is defeated by the caching done in Strategy
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1350
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1350
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Gary Dusbabek
> Fix For: 0.7 beta 1
>
>
> can we move the caching into AbstractEndpointSnitch instead?
> also: AES.register appears to never be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1350) DynamicEndpointSnitch is
defeated by the caching done in Strategy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896256#action_12896256 ]
Jonathan Ellis commented on CASSANDRA-1350:
-------------------------------------------
won't those be taken care of by the every-10-minutes global invalidate?
> DynamicEndpointSnitch is defeated by the caching done in Strategy
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1350
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1350
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Gary Dusbabek
> Fix For: 0.7 beta 1
>
> Attachments: 0001-move-endpoint-cache-from-ARS-to-AES.patch
>
>
> can we move the caching into AbstractEndpointSnitch instead?
> also: AES.register appears to never be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.