You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Baptiste Mathus <bm...@batmat.net> on 2014/04/28 13:35:06 UTC
[Committer School] ARCHETYPE-456
Hi all,
http://jira.codehaus.org/browse/ARCHETYPE-456
If you think anything is missing or disagree with the issue rationale, just
let know. We're currently having a local release for that patch and I'd be
really happy to know I'll be able to get rid of it some day (or not ;-)).
Thanks
--
Baptiste
Re: [Committer School] ARCHETYPE-456
Posted by Baptiste Mathus <bm...@batmat.net>.
Thanks a lot for the review, I'll have a look very soon to improve the IT.
Cheers
2014-04-28 13:50 GMT+02:00 Stephen Connolly <stephen.alan.connolly@gmail.com
>:
> >
> > [INFO] --- maven-invoker-plugin:1.7:run (integration-test) @
> > maven-archetype-plugin ---
> > [INFO] Building: build-archetype/pom.xml
> > [INFO] ..FAILED (1.8 s)
> > [INFO] The build exited with code 1. See
> >
> /Users/stephenc/apache/maven-archetype/maven-archetype-plugin/target/it/build-archetype/build.log
> > for details.
> > [INFO] Building: build-archetype-ignore-eol-encoding/pom.xml
> > [INFO] ..FAILED (3.2 s)
> > [INFO] The build exited with code 1. See
> >
> /Users/stephenc/apache/maven-archetype/maven-archetype-plugin/target/it/build-archetype-ignore-eol-encoding/build.log
> > for details.
> > [INFO] Building: create-from-project/pom.xml
> > [INFO] run script verify.bsh
> > [INFO] ..SUCCESS (4.7 s)
> > [INFO] Building: generate-basic
> > [INFO] run script setup.groovy
> > [INFO] run script verify.bsh
> > [INFO] ..SUCCESS (5.4 s)
> > [INFO] Building: property-setting-cli/pom.xml
> > [INFO] ..FAILED (1.6 s)
> > [INFO] The build exited with code 1. See
> >
> /Users/stephenc/apache/maven-archetype/maven-archetype-plugin/target/it/property-setting-cli/build.log
> > for details.
> > [INFO] -------------------------------------------------
> > [INFO] Build Summary:
> > [INFO] Passed: 2, Failed: 3, Errors: 0, Skipped: 0
> > [INFO] -------------------------------------------------
> > [ERROR] The following builds failed:
> > [ERROR] * build-archetype/pom.xml
> > [ERROR] * build-archetype-ignore-eol-encoding/pom.xml
> > [ERROR] * property-setting-cli/pom.xml
> > [INFO] -------------------------------------------------
>
>
> I was almost about to commit your patch...
>
> I think the problem is that you are assuming people will build always using
> the "install" phase.
>
> Here is one of the build logs
>
> [ERROR] The build could not read 1 project -> [Help 1]
> > org.apache.maven.project.ProjectBuildingException: Some problems were
> > encountered while processing the POMs:
> > [ERROR] Unresolveable build extension: Plugin
> > org.apache.maven.archetype:archetype-packaging:2.3-SNAPSHOT or one of its
> > dependencies could not be resolved: Could not find artifact
> > org.apache.maven.archetype:archetype-packaging:jar:2.3-SNAPSHOT in
> > local.central (file:///Users/stephenc/.m2/repository) @
> > [ERROR] Unknown packaging: maven-archetype @ line 29, column 14
> > at
> >
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:364)
> > at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:672)
> > at
> >
> org.apache.maven.DefaultMaven.getProjectsForMavenReactor(DefaultMaven.java:663)
> > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:250)
> > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
> > at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at
> >
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at
> >
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at
> >
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> > at
> >
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> > at
> >
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> > at
> > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> > [ERROR]
> > [ERROR] The project
> > org.apache.maven.plugins.archetype.its:build-archetype:1.0-SNAPSHOT
> >
> (/Users/stephenc/apache/maven-archetype/maven-archetype-plugin/target/it/build-archetype/pom.xml)
> > has 2 errors
> > [ERROR] Unresolveable build extension: Plugin
> > org.apache.maven.archetype:archetype-packaging:2.3-SNAPSHOT or one of its
> > dependencies could not be resolved: Could not find artifact
> > org.apache.maven.archetype:archetype-packaging:jar:2.3-SNAPSHOT in
> > local.central (file:///Users/stephenc/.m2/repository) -> [Help 2]
> > org.apache.maven.plugin.PluginResolutionException: Plugin
> > org.apache.maven.archetype:archetype-packaging:2.3-SNAPSHOT or one of its
> > dependencies could not be resolved: Could not find artifact
> > org.apache.maven.archetype:archetype-packaging:jar:2.3-SNAPSHOT in
> > local.central (file:///Users/stephenc/.m2/repository)
> > at
> >
> org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolve(DefaultPluginDependenciesResolver.java:208)
> > at
> >
> org.apache.maven.project.DefaultProjectBuildingHelper.resolveExtensionArtifacts(DefaultProjectBuildingHelper.java:380)
> > at
> >
> org.apache.maven.project.DefaultProjectBuildingHelper.createProjectRealm(DefaultProjectBuildingHelper.java:239)
> > at
> >
> org.apache.maven.project.DefaultModelBuildingListener.buildExtensionsAssembled(DefaultModelBuildingListener.java:110)
> > at
> >
> org.apache.maven.model.building.ModelBuildingEventCatapult$1.fire(ModelBuildingEventCatapult.java:43)
> > at
> >
> org.apache.maven.model.building.DefaultModelBuilder.fireEvent(DefaultModelBuilder.java:1069)
> > at
> >
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:385)
> > at
> >
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:368)
> > at
> >
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:561)
> > at
> >
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:353)
> > at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:672)
> > at
> >
> org.apache.maven.DefaultMaven.getProjectsForMavenReactor(DefaultMaven.java:663)
> > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:250)
> > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
> > at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at
> >
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at
> >
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:606)
> > at
> >
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> > at
> >
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> > at
> >
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> > at
> > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> > Caused by: org.eclipse.aether.resolution.ArtifactResolutionException:
> > Could not find artifact
> > org.apache.maven.archetype:archetype-packaging:jar:2.3-SNAPSHOT in
> > local.central (file:///Users/stephenc/.m2/repository)
> > at
> >
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:459)
> > at
> >
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:262)
> > at
> >
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:367)
> > at
> >
> org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolve(DefaultPluginDependenciesResolver.java:200)
> > ... 24 more
> > Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could
> > not find artifact
> > org.apache.maven.archetype:archetype-packaging:jar:2.3-SNAPSHOT in
> > local.central (file:///Users/stephenc/.m2/repository)
> > at
> >
> org.eclipse.aether.connector.wagon.WagonRepositoryConnector$6.wrap(WagonRepositoryConnector.java:1012)
> > at
> >
> org.eclipse.aether.connector.wagon.WagonRepositoryConnector$6.wrap(WagonRepositoryConnector.java:1004)
> > at
> >
> org.eclipse.aether.connector.wagon.WagonRepositoryConnector$GetTask.run(WagonRepositoryConnector.java:725)
> > at
> >
> org.eclipse.aether.util.concurrency.RunnableErrorForwarder$1.run(RunnableErrorForwarder.java:67)
> > at
> >
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> > at
> >
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> > at java.lang.Thread.run(Thread.java:744)
> > [ERROR] Unknown packaging: maven-archetype @ line 29, column 14
> > [ERROR]
> > [ERROR]
> > [ERROR] For more information about the errors and possible solutions,
> > please read the following articles:
> > [ERROR] [Help 1]
> >
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> > [ERROR] [Help 2]
> >
> http://cwiki.apache.org/confluence/display/MAVEN/PluginResolutionException
> >
>
> Thus while the patch will pass tests from a polluted local repo as soon as
> somebody tries to cut the official release, release:prepare will barf out.
>
> The tests need tweaking
>
>
> On 28 April 2014 12:35, Baptiste Mathus <bm...@batmat.net> wrote:
>
> > Hi all,
> >
> > http://jira.codehaus.org/browse/ARCHETYPE-456
> >
> > If you think anything is missing or disagree with the issue rationale,
> just
> > let know. We're currently having a local release for that patch and I'd
> be
> > really happy to know I'll be able to get rid of it some day (or not ;-)).
> >
> > Thanks
> >
> > --
> > Baptiste
> >
>
--
Baptiste <Batmat> MATHUS - http://batmat.net
Sauvez un arbre,
Mangez un castor !
Re: [Committer School] ARCHETYPE-456
Posted by Stephen Connolly <st...@gmail.com>.
>
> [INFO] --- maven-invoker-plugin:1.7:run (integration-test) @
> maven-archetype-plugin ---
> [INFO] Building: build-archetype/pom.xml
> [INFO] ..FAILED (1.8 s)
> [INFO] The build exited with code 1. See
> /Users/stephenc/apache/maven-archetype/maven-archetype-plugin/target/it/build-archetype/build.log
> for details.
> [INFO] Building: build-archetype-ignore-eol-encoding/pom.xml
> [INFO] ..FAILED (3.2 s)
> [INFO] The build exited with code 1. See
> /Users/stephenc/apache/maven-archetype/maven-archetype-plugin/target/it/build-archetype-ignore-eol-encoding/build.log
> for details.
> [INFO] Building: create-from-project/pom.xml
> [INFO] run script verify.bsh
> [INFO] ..SUCCESS (4.7 s)
> [INFO] Building: generate-basic
> [INFO] run script setup.groovy
> [INFO] run script verify.bsh
> [INFO] ..SUCCESS (5.4 s)
> [INFO] Building: property-setting-cli/pom.xml
> [INFO] ..FAILED (1.6 s)
> [INFO] The build exited with code 1. See
> /Users/stephenc/apache/maven-archetype/maven-archetype-plugin/target/it/property-setting-cli/build.log
> for details.
> [INFO] -------------------------------------------------
> [INFO] Build Summary:
> [INFO] Passed: 2, Failed: 3, Errors: 0, Skipped: 0
> [INFO] -------------------------------------------------
> [ERROR] The following builds failed:
> [ERROR] * build-archetype/pom.xml
> [ERROR] * build-archetype-ignore-eol-encoding/pom.xml
> [ERROR] * property-setting-cli/pom.xml
> [INFO] -------------------------------------------------
I was almost about to commit your patch...
I think the problem is that you are assuming people will build always using
the "install" phase.
Here is one of the build logs
[ERROR] The build could not read 1 project -> [Help 1]
> org.apache.maven.project.ProjectBuildingException: Some problems were
> encountered while processing the POMs:
> [ERROR] Unresolveable build extension: Plugin
> org.apache.maven.archetype:archetype-packaging:2.3-SNAPSHOT or one of its
> dependencies could not be resolved: Could not find artifact
> org.apache.maven.archetype:archetype-packaging:jar:2.3-SNAPSHOT in
> local.central (file:///Users/stephenc/.m2/repository) @
> [ERROR] Unknown packaging: maven-archetype @ line 29, column 14
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:364)
> at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:672)
> at
> org.apache.maven.DefaultMaven.getProjectsForMavenReactor(DefaultMaven.java:663)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:250)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> [ERROR]
> [ERROR] The project
> org.apache.maven.plugins.archetype.its:build-archetype:1.0-SNAPSHOT
> (/Users/stephenc/apache/maven-archetype/maven-archetype-plugin/target/it/build-archetype/pom.xml)
> has 2 errors
> [ERROR] Unresolveable build extension: Plugin
> org.apache.maven.archetype:archetype-packaging:2.3-SNAPSHOT or one of its
> dependencies could not be resolved: Could not find artifact
> org.apache.maven.archetype:archetype-packaging:jar:2.3-SNAPSHOT in
> local.central (file:///Users/stephenc/.m2/repository) -> [Help 2]
> org.apache.maven.plugin.PluginResolutionException: Plugin
> org.apache.maven.archetype:archetype-packaging:2.3-SNAPSHOT or one of its
> dependencies could not be resolved: Could not find artifact
> org.apache.maven.archetype:archetype-packaging:jar:2.3-SNAPSHOT in
> local.central (file:///Users/stephenc/.m2/repository)
> at
> org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolve(DefaultPluginDependenciesResolver.java:208)
> at
> org.apache.maven.project.DefaultProjectBuildingHelper.resolveExtensionArtifacts(DefaultProjectBuildingHelper.java:380)
> at
> org.apache.maven.project.DefaultProjectBuildingHelper.createProjectRealm(DefaultProjectBuildingHelper.java:239)
> at
> org.apache.maven.project.DefaultModelBuildingListener.buildExtensionsAssembled(DefaultModelBuildingListener.java:110)
> at
> org.apache.maven.model.building.ModelBuildingEventCatapult$1.fire(ModelBuildingEventCatapult.java:43)
> at
> org.apache.maven.model.building.DefaultModelBuilder.fireEvent(DefaultModelBuilder.java:1069)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:385)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:368)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:561)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:353)
> at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:672)
> at
> org.apache.maven.DefaultMaven.getProjectsForMavenReactor(DefaultMaven.java:663)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:250)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.eclipse.aether.resolution.ArtifactResolutionException:
> Could not find artifact
> org.apache.maven.archetype:archetype-packaging:jar:2.3-SNAPSHOT in
> local.central (file:///Users/stephenc/.m2/repository)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:459)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:262)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:367)
> at
> org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolve(DefaultPluginDependenciesResolver.java:200)
> ... 24 more
> Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could
> not find artifact
> org.apache.maven.archetype:archetype-packaging:jar:2.3-SNAPSHOT in
> local.central (file:///Users/stephenc/.m2/repository)
> at
> org.eclipse.aether.connector.wagon.WagonRepositoryConnector$6.wrap(WagonRepositoryConnector.java:1012)
> at
> org.eclipse.aether.connector.wagon.WagonRepositoryConnector$6.wrap(WagonRepositoryConnector.java:1004)
> at
> org.eclipse.aether.connector.wagon.WagonRepositoryConnector$GetTask.run(WagonRepositoryConnector.java:725)
> at
> org.eclipse.aether.util.concurrency.RunnableErrorForwarder$1.run(RunnableErrorForwarder.java:67)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
> [ERROR] Unknown packaging: maven-archetype @ line 29, column 14
> [ERROR]
> [ERROR]
> [ERROR] For more information about the errors and possible solutions,
> please read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> [ERROR] [Help 2]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginResolutionException
>
Thus while the patch will pass tests from a polluted local repo as soon as
somebody tries to cut the official release, release:prepare will barf out.
The tests need tweaking
On 28 April 2014 12:35, Baptiste Mathus <bm...@batmat.net> wrote:
> Hi all,
>
> http://jira.codehaus.org/browse/ARCHETYPE-456
>
> If you think anything is missing or disagree with the issue rationale, just
> let know. We're currently having a local release for that patch and I'd be
> really happy to know I'll be able to get rid of it some day (or not ;-)).
>
> Thanks
>
> --
> Baptiste
>