You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Aaron Kimball (JIRA)" <ji...@apache.org> on 2009/10/24 02:01:59 UTC
[jira] Created: (MAPREDUCE-1148) SQL identifiers are a superset of
Java identifiers
SQL identifiers are a superset of Java identifiers
--------------------------------------------------
Key: MAPREDUCE-1148
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: contrib/sqoop
Reporter: Aaron Kimball
Assignee: Aaron Kimball
SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1148) SQL identifiers are a superset
of Java identifiers
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796722#action_12796722 ]
Hudson commented on MAPREDUCE-1148:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #196 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/196/])
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1148.2.patch, MAPREDUCE-1148.3.patch, MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1148) SQL identifiers are a superset
of Java identifiers
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781509#action_12781509 ]
Tom White commented on MAPREDUCE-1148:
--------------------------------------
+1 looks good overall.
If you made JAVA_RESERVED_WORDS a HashSet then isReservedWord() would be a one-liner.
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1148) SQL identifiers are a superset of
Java identifiers
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1148:
-------------------------------------
Attachment: MAPREDUCE-1148.2.patch
New patch; uses HashSet where indicated.
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1148.2.patch, MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1148) SQL identifiers are a superset of
Java identifiers
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1148:
-------------------------------------
Status: Patch Available (was: Open)
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1148) SQL identifiers are a superset of
Java identifiers
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1148:
-------------------------------------
Status: Open (was: Patch Available)
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1148.2.patch, MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1148) SQL identifiers are a superset of
Java identifiers
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1148:
-------------------------------------
Status: Patch Available (was: Open)
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1148.2.patch, MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1148) SQL identifiers are a superset of
Java identifiers
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1148:
-------------------------------------
Status: Patch Available (was: Open)
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1148.2.patch, MAPREDUCE-1148.3.patch, MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1148) SQL identifiers are a superset of
Java identifiers
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1148:
-------------------------------------
Attachment: MAPREDUCE-1148.patch
Attaching patch to address the issue.
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1148) SQL identifiers are a superset of
Java identifiers
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1148:
-------------------------------------
Attachment: MAPREDUCE-1148.3.patch
New patch; resynced with trunk.
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1148.2.patch, MAPREDUCE-1148.3.patch, MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1148) SQL identifiers are a superset
of Java identifiers
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787793#action_12787793 ]
Hadoop QA commented on MAPREDUCE-1148:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12427371/MAPREDUCE-1148.3.patch
against trunk revision 888431.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/304/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/304/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/304/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/304/console
This message is automatically generated.
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1148.2.patch, MAPREDUCE-1148.3.patch, MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1148) SQL identifiers are a superset of
Java identifiers
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1148:
-------------------------------------
Status: Open (was: Patch Available)
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1148.2.patch, MAPREDUCE-1148.3.patch, MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1148) SQL identifiers are a superset
of Java identifiers
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769575#action_12769575 ]
Hadoop QA commented on MAPREDUCE-1148:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12423084/MAPREDUCE-1148.patch
against trunk revision 829281.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/207/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/207/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/207/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/207/console
This message is automatically generated.
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1148) SQL identifiers are a superset of
Java identifiers
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-1148:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Aaron!
> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
> Key: MAPREDUCE-1148
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1148.2.patch, MAPREDUCE-1148.3.patch, MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.