You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/19 05:29:27 UTC
[jira] [Commented] (SOLR-9997) Enable configuring
SolrHttpClientBuilder via java system property
[ https://issues.apache.org/jira/browse/SOLR-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829342#comment-15829342 ]
ASF GitHub Bot commented on SOLR-9997:
--------------------------------------
GitHub user hgadre opened a pull request:
https://github.com/apache/lucene-solr/pull/140
[SOLR-9997] Enable configuring SolrHttpClientBuilder via java system …
…property
- Added support to configure SolrHttpClientBuilder via java system property
- Added a concrete implementation of HttpClientBuilderFactory which supports
preemptive basic authentication.
- Removed the hardcoded basic auth support from SolrCLI (and verified that
it works with basic auth plugin as well as with kerberos).
- Added support to log HTTP request/response for debugging authentication issues
in HadoopAuthPlugin.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hgadre/lucene-solr SOLR-9997_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #140
----
commit 852668b0c7977aea9d73541e7d36e74e30165079
Author: Hrishikesh Gadre <hg...@cloudera.com>
Date: 2017-01-18T20:31:20Z
[SOLR-9997] Enable configuring SolrHttpClientBuilder via java system property
- Added support to configure SolrHttpClientBuilder via java system property
- Added a concrete implementation of HttpClientBuilderFactory which supports
preemptive basic authentication.
- Removed the hardcoded basic auth support from SolrCLI (and verified that
it works with basic auth plugin as well as with kerberos).
- Added support to log HTTP request/response for debugging authentication issues
in HadoopAuthPlugin.
----
> Enable configuring SolrHttpClientBuilder via java system property
> -----------------------------------------------------------------
>
> Key: SOLR-9997
> URL: https://issues.apache.org/jira/browse/SOLR-9997
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 6.3
> Reporter: Hrishikesh Gadre
>
> Currently SolrHttpClientBuilder needs to be configured via invoking HttpClientUtil#setHttpClientBuilder(...) API. On the other hand SolrCLI attempts to support configuring SolrHttpClientBuilder via Java system property. https://github.com/apache/lucene-solr/blob/9f58b6cd177f72b226c83adbb965cfe08d61d2fb/solr/core/src/java/org/apache/solr/util/SolrCLI.java#L265
> But after changes for SOLR-4509, this is no longer working. This is because we need to configure HttpClientBuilderFactory which can provide appropriate SolrHttpClientBuilder instance (e.g. Krb5HttpClientBuilder). I verified that SolrCLI does not work in a kerberos enabled cluster. During the testing I also found that SolrCLI is hardcoded to use basic authentication,
> https://github.com/apache/lucene-solr/blob/9f58b6cd177f72b226c83adbb965cfe08d61d2fb/solr/core/src/java/org/apache/solr/util/SolrCLI.java#L156
> This jira is to add support for configuring HttpClientBuilderFactory as a java system property so that SolrCLI as well as other Solr clients can also benefit this. Also we should provide a HttpClientBuilderFactory which support configuring preemptive basic authentication so that we can remove the hardcoded basic auth usage in SolrCLI (and enable it work with kerberos).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org