You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/04/22 12:31:43 UTC
[GitHub] [druid] NoamShaish opened a new pull request #11148: fix Dockerfile steps order
NoamShaish opened a new pull request #11148:
URL: https://github.com/apache/druid/pull/11148
Fixes #11137.
### Description
This PR fix the Docker build sequence which is broken.
I moved the copy of the builder opt directory to be before the creation of /opt/druid/var since it collides with the copied content.
##### Key changed/added files in this PR
* `/distribution/docker/Dockerfile`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl commented on pull request #11148: fix Dockerfile steps order
Posted by GitBox <gi...@apache.org>.
xvrl commented on pull request #11148:
URL: https://github.com/apache/druid/pull/11148#issuecomment-829789048
Hi @NoamShaish, your change seems to undo the docker image size optimization introduced in #10506 which introduced this bug. I believe #11167 should fix the problem while avoiding the increase in the image size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org