You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/11/14 22:38:59 UTC
Re: Review Request 63804: Added plumbing for operation reconciliation
between master and agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63804/
-----------------------------------------------------------
(Updated Nov. 14, 2017, 10:38 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Summary (updated)
-----------------
Added plumbing for operation reconciliation between master and agent.
Bugs: MESOS-8199
https://issues.apache.org/jira/browse/MESOS-8199
Repository: mesos
Description (updated)
-------
This patch adds new internal protobuf messages to be used by the master
and agent when reconciling pending/unacknowledged offer operations. It
also adds a stub handler to the agent.
Diffs
-----
include/mesos/resource_provider/resource_provider.proto 1e44b952691fa57b546e979bc5876df3d82d746f
src/messages/messages.proto 33732e28d087a17080eb9aa7d9a91c367172be7f
src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f
src/slave/slave.hpp c0acaa639a2bacaa6955ae6c5ab41e75dc1d11f7
src/slave/slave.cpp d8bacebc74790e955490a158c37ac0d9e75fd6b5
Diff: https://reviews.apache.org/r/63804/diff/3/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63804: Added plumbing for master to reconcile offer
operations with agent.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63804/#review192350
-----------------------------------------------------------
include/mesos/resource_provider/resource_provider.proto
Lines 39 (patched)
<https://reviews.apache.org/r/63804/#comment270448>
Can you also update v1 proto?
- Jie Yu
On Nov. 30, 2017, 6:20 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63804/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 6:20 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8199
> https://issues.apache.org/jira/browse/MESOS-8199
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds infrastructure to allow the master to explicitly
> reconcile pending offer operations with the agent after the agent
> has reregistered or updated its state.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 615a2ab8a00f4da3906ad0ae322a885c84b3574b
> src/messages/messages.proto d7ef68f85a9f8a7702a83a3554c2dedc6d7ee339
> src/resource_provider/manager.hpp e7a9a6cc6b15372d8f3f11e17fa2297792b00ff9
> src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00
> src/resource_provider/storage/provider.cpp 49c042cdb1837860aaedde2e48f318ed5ac8b1d1
> src/slave/slave.hpp d538a8baf970b9e127fc8c14a9e300fb2dd58a93
> src/slave/slave.cpp cd716476dfad619dc6cf7449a32a27842efbe7fb
>
>
> Diff: https://reviews.apache.org/r/63804/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63804: Added plumbing for master to reconcile offer
operations with agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63804/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 7:39 a.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8199
https://issues.apache.org/jira/browse/MESOS-8199
Repository: mesos
Description (updated)
-------
Added plumbing for master to reconcile offer operations with agent.
Diffs (updated)
-----
include/mesos/resource_provider/resource_provider.proto 2ce71f4c3e97e89c226966c347c2817e2bab9c1b
include/mesos/v1/resource_provider/resource_provider.proto 465b11dafd7c2e3b9476696ed75c1c077d6c8eeb
src/messages/messages.proto 2ab0fe8400a2de2318368d1b408b266ce647339d
src/resource_provider/manager.hpp c2aeb15b0b8ebd167ddf9c42c9fc396d4c0a126b
src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe
src/resource_provider/storage/provider.cpp d35b0d02992e3730ca47906b34c21e1ba9c653e7
src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059
src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc
src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2
Diff: https://reviews.apache.org/r/63804/diff/7/
Changes: https://reviews.apache.org/r/63804/diff/6-7/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63804: Added plumbing for master to reconcile offer
operations with agent.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Nov. 30, 2017, 7:49 p.m., Jie Yu wrote:
> > include/mesos/resource_provider/resource_provider.proto
> > Lines 39 (patched)
> > <https://reviews.apache.org/r/63804/diff/6/?file=1904718#file1904718line39>
> >
> > For the sake of consistency. I think we should either rename this to `RECONCILE`, or rename above types to `ACKNOWLEDGE_OFFER_OPERATION` and `APPLY_OFFER_OPERATION` and `PUBLISH_RESOURCES`
I renamed to ACKNOWLEDGE_OFFER_OPERATION in a previous review, but I have not updated PUBLISH_RESOURCES yet. I'll resolve this issue once I submit a patch for that, and will leave a link here.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63804/#review192349
-----------------------------------------------------------
On Dec. 5, 2017, 7:39 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63804/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 7:39 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8199
> https://issues.apache.org/jira/browse/MESOS-8199
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added plumbing for master to reconcile offer operations with agent.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 2ce71f4c3e97e89c226966c347c2817e2bab9c1b
> include/mesos/v1/resource_provider/resource_provider.proto 465b11dafd7c2e3b9476696ed75c1c077d6c8eeb
> src/messages/messages.proto 2ab0fe8400a2de2318368d1b408b266ce647339d
> src/resource_provider/manager.hpp c2aeb15b0b8ebd167ddf9c42c9fc396d4c0a126b
> src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe
> src/resource_provider/storage/provider.cpp d35b0d02992e3730ca47906b34c21e1ba9c653e7
> src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059
> src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc
> src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2
>
>
> Diff: https://reviews.apache.org/r/63804/diff/7/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63804: Added plumbing for master to reconcile offer
operations with agent.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Nov. 30, 2017, 7:49 p.m., Jie Yu wrote:
> > include/mesos/resource_provider/resource_provider.proto
> > Lines 39 (patched)
> > <https://reviews.apache.org/r/63804/diff/6/?file=1904718#file1904718line39>
> >
> > For the sake of consistency. I think we should either rename this to `RECONCILE`, or rename above types to `ACKNOWLEDGE_OFFER_OPERATION` and `APPLY_OFFER_OPERATION` and `PUBLISH_RESOURCES`
>
> Greg Mann wrote:
> I renamed to ACKNOWLEDGE_OFFER_OPERATION in a previous review, but I have not updated PUBLISH_RESOURCES yet. I'll resolve this issue once I submit a patch for that, and will leave a link here.
I added follow-up reviews to rename events/calls here:
https://reviews.apache.org/r/64398/
https://reviews.apache.org/r/64398/
https://reviews.apache.org/r/64400/
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63804/#review192349
-----------------------------------------------------------
On Dec. 5, 2017, 7:39 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63804/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 7:39 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8199
> https://issues.apache.org/jira/browse/MESOS-8199
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added plumbing for master to reconcile offer operations with agent.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 2ce71f4c3e97e89c226966c347c2817e2bab9c1b
> include/mesos/v1/resource_provider/resource_provider.proto 465b11dafd7c2e3b9476696ed75c1c077d6c8eeb
> src/messages/messages.proto 2ab0fe8400a2de2318368d1b408b266ce647339d
> src/resource_provider/manager.hpp c2aeb15b0b8ebd167ddf9c42c9fc396d4c0a126b
> src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe
> src/resource_provider/storage/provider.cpp d35b0d02992e3730ca47906b34c21e1ba9c653e7
> src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059
> src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc
> src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2
>
>
> Diff: https://reviews.apache.org/r/63804/diff/7/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63804: Added plumbing for master to reconcile offer
operations with agent.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63804/#review192349
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/resource_provider/resource_provider.proto
Lines 39 (patched)
<https://reviews.apache.org/r/63804/#comment270446>
For the sake of consistency. I think we should either rename this to `RECONCILE`, or rename above types to `ACKNOWLEDGE_OFFER_OPERATION` and `APPLY_OFFER_OPERATION` and `PUBLISH_RESOURCES`
include/mesos/resource_provider/resource_provider.proto
Lines 91 (patched)
<https://reviews.apache.org/r/63804/#comment270447>
s/master/resource provieer manager/
- Jie Yu
On Nov. 30, 2017, 6:20 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63804/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 6:20 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8199
> https://issues.apache.org/jira/browse/MESOS-8199
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds infrastructure to allow the master to explicitly
> reconcile pending offer operations with the agent after the agent
> has reregistered or updated its state.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 615a2ab8a00f4da3906ad0ae322a885c84b3574b
> src/messages/messages.proto d7ef68f85a9f8a7702a83a3554c2dedc6d7ee339
> src/resource_provider/manager.hpp e7a9a6cc6b15372d8f3f11e17fa2297792b00ff9
> src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00
> src/resource_provider/storage/provider.cpp 49c042cdb1837860aaedde2e48f318ed5ac8b1d1
> src/slave/slave.hpp d538a8baf970b9e127fc8c14a9e300fb2dd58a93
> src/slave/slave.cpp cd716476dfad619dc6cf7449a32a27842efbe7fb
>
>
> Diff: https://reviews.apache.org/r/63804/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63804: Added plumbing for master to reconcile offer
operations with agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63804/
-----------------------------------------------------------
(Updated Nov. 30, 2017, 6:20 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Summary (updated)
-----------------
Added plumbing for master to reconcile offer operations with agent.
Bugs: MESOS-8199
https://issues.apache.org/jira/browse/MESOS-8199
Repository: mesos
Description (updated)
-------
This patch adds infrastructure to allow the master to explicitly
reconcile pending offer operations with the agent after the agent
has reregistered or updated its state.
Diffs (updated)
-----
include/mesos/resource_provider/resource_provider.proto 615a2ab8a00f4da3906ad0ae322a885c84b3574b
src/messages/messages.proto d7ef68f85a9f8a7702a83a3554c2dedc6d7ee339
src/resource_provider/manager.hpp e7a9a6cc6b15372d8f3f11e17fa2297792b00ff9
src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00
src/resource_provider/storage/provider.cpp 49c042cdb1837860aaedde2e48f318ed5ac8b1d1
src/slave/slave.hpp d538a8baf970b9e127fc8c14a9e300fb2dd58a93
src/slave/slave.cpp cd716476dfad619dc6cf7449a32a27842efbe7fb
Diff: https://reviews.apache.org/r/63804/diff/6/
Changes: https://reviews.apache.org/r/63804/diff/5-6/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63804: Added plumbing for operation reconciliation
between master and agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63804/
-----------------------------------------------------------
(Updated Nov. 15, 2017, 9:51 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Changes
-------
Rebase.
Bugs: MESOS-8199
https://issues.apache.org/jira/browse/MESOS-8199
Repository: mesos
Description
-------
This patch adds new internal protobuf messages to be used by the master
and agent when reconciling pending/unacknowledged offer operations.
Diffs (updated)
-----
include/mesos/resource_provider/resource_provider.proto 1e44b952691fa57b546e979bc5876df3d82d746f
src/messages/messages.proto 33732e28d087a17080eb9aa7d9a91c367172be7f
src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f
src/slave/slave.hpp 40442f25ae1b223380e11f8602e6256c9203ef47
src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0
Diff: https://reviews.apache.org/r/63804/diff/5/
Changes: https://reviews.apache.org/r/63804/diff/4-5/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63804: Added plumbing for operation reconciliation
between master and agent.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63804/#review191027
-----------------------------------------------------------
PASS: Mesos patch 63804 was successfully built and tested.
Reviews applied: `['63767', '63768', '63804']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63804
- Mesos Reviewbot Windows
On Nov. 14, 2017, 10:56 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63804/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2017, 10:56 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8199
> https://issues.apache.org/jira/browse/MESOS-8199
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds new internal protobuf messages to be used by the master
> and agent when reconciling pending/unacknowledged offer operations.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 1e44b952691fa57b546e979bc5876df3d82d746f
> src/messages/messages.proto 33732e28d087a17080eb9aa7d9a91c367172be7f
> src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f
> src/slave/slave.hpp c0acaa639a2bacaa6955ae6c5ab41e75dc1d11f7
> src/slave/slave.cpp d8bacebc74790e955490a158c37ac0d9e75fd6b5
>
>
> Diff: https://reviews.apache.org/r/63804/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63804: Added plumbing for operation reconciliation
between master and agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63804/
-----------------------------------------------------------
(Updated Nov. 14, 2017, 10:56 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8199
https://issues.apache.org/jira/browse/MESOS-8199
Repository: mesos
Description (updated)
-------
This patch adds new internal protobuf messages to be used by the master
and agent when reconciling pending/unacknowledged offer operations.
Diffs (updated)
-----
include/mesos/resource_provider/resource_provider.proto 1e44b952691fa57b546e979bc5876df3d82d746f
src/messages/messages.proto 33732e28d087a17080eb9aa7d9a91c367172be7f
src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f
src/slave/slave.hpp c0acaa639a2bacaa6955ae6c5ab41e75dc1d11f7
src/slave/slave.cpp d8bacebc74790e955490a158c37ac0d9e75fd6b5
Diff: https://reviews.apache.org/r/63804/diff/4/
Changes: https://reviews.apache.org/r/63804/diff/3-4/
Testing
-------
make check
Thanks,
Greg Mann