You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "kevinrr888 (via GitHub)" <gi...@apache.org> on 2024/09/17 21:04:20 UTC

[PR] fix issue with converting text to string in MetadataConstraints in 3.x [accumulo]

kevinrr888 opened a new pull request, #4897:
URL: https://github.com/apache/accumulo/pull/4897

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix issue with converting text to string in MetadataConstraints in 3.x [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4897:
URL: https://github.com/apache/accumulo/pull/4897#discussion_r1764022099


##########
server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java:
##########
@@ -369,8 +369,7 @@ private void validateServerFamily(ArrayList<Short> violations, ColumnUpdate colu
   private void validateSuspendLocationFamily(ArrayList<Short> violations,
       ColumnUpdate columnUpdate) {
     String qualStr = new String(columnUpdate.getColumnQualifier(), UTF_8);
-    String suspendColQualStr =
-        new String(SuspendLocationColumn.SUSPEND_COLUMN.getColumnQualifier().getBytes(), UTF_8);
+    String suspendColQualStr = SuspendLocationColumn.SUSPEND_COLUMN.getColumnQualifier().toString();

Review Comment:
   We could make a constant for this String.  For this case do not need to keep recomputing the string.  Could add that constant to the SuspendLocationColumn.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix issue with converting text to string in MetadataConstraints in 3.x [accumulo]

Posted by "kevinrr888 (via GitHub)" <gi...@apache.org>.
kevinrr888 merged PR #4897:
URL: https://github.com/apache/accumulo/pull/4897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix issue with converting text to string in MetadataConstraints in 3.x [accumulo]

Posted by "kevinrr888 (via GitHub)" <gi...@apache.org>.
kevinrr888 commented on code in PR #4897:
URL: https://github.com/apache/accumulo/pull/4897#discussion_r1765166960


##########
server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java:
##########
@@ -369,8 +369,7 @@ private void validateServerFamily(ArrayList<Short> violations, ColumnUpdate colu
   private void validateSuspendLocationFamily(ArrayList<Short> violations,
       ColumnUpdate columnUpdate) {
     String qualStr = new String(columnUpdate.getColumnQualifier(), UTF_8);
-    String suspendColQualStr =
-        new String(SuspendLocationColumn.SUSPEND_COLUMN.getColumnQualifier().getBytes(), UTF_8);
+    String suspendColQualStr = SuspendLocationColumn.SUSPEND_COLUMN.getColumnQualifier().toString();

Review Comment:
   Added. Also checked the other columns in MetadataSchema; SuspendLocationColumn was the only one that wasn't consistent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org