You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/20 09:21:58 UTC
[GitHub] [hbase] ramkrish86 commented on a change in pull request #1062:
HBASE-23705 Add CellComparator to HFileContext
ramkrish86 commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r368439982
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java
##########
@@ -131,8 +131,7 @@ private int binarySearch(Cell seekCell, boolean seekBefore) {
int comp = 0;
while (low <= high) {
mid = low + ((high - low) >> 1);
- ByteBuffer row = getRow(mid);
- comp = compareRows(row, seekCell);
+ comp = this.cellComparator.compareRows(getRow(mid), seekCell);
Review comment:
I too agree to @anoopsjohn . Seems we deliberately left this compareRows() here. Is there a similar compareRows in every encoder?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services