You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/04/08 00:47:22 UTC
[GitHub] [hadoop] jojochuang opened a new pull request #1945: HDFS-15269. NameNode should check the authorization API version only …
jojochuang opened a new pull request #1945: HDFS-15269. NameNode should check the authorization API version only …
URL: https://github.com/apache/hadoop/pull/1945
…once during initialization.
Change-Id: I83b2146164b996c14c685cf9a7c62d2f48ec2315
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
URL: https://github.com/apache/hadoop/pull/1945#issuecomment-610740611
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 20s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 23m 43s | trunk passed |
| +1 :green_heart: | compile | 1m 16s | trunk passed |
| +1 :green_heart: | checkstyle | 0m 49s | trunk passed |
| +1 :green_heart: | mvnsite | 1m 23s | trunk passed |
| +1 :green_heart: | shadedclient | 18m 7s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 47s | trunk passed |
| +0 :ok: | spotbugs | 3m 21s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 18s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 18s | the patch passed |
| +1 :green_heart: | compile | 1m 9s | the patch passed |
| +1 :green_heart: | javac | 1m 9s | the patch passed |
| -0 :warning: | checkstyle | 0m 43s | hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 74 unchanged - 0 fixed = 75 total (was 74) |
| +1 :green_heart: | mvnsite | 1m 16s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 16m 0s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 42s | the patch passed |
| -1 :x: | findbugs | 3m 27s | hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
||| _ Other Tests _ |
| -1 :x: | unit | 123m 17s | hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. |
| | | 200m 40s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs |
| | Null passed for non-null parameter of FSDirectory.setINodeAttributeProvider(INodeAttributeProvider) in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.stopCommonServices() At FSNamesystem.java:of FSDirectory.setINodeAttributeProvider(INodeAttributeProvider) in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.stopCommonServices() At FSNamesystem.java:[line 1297] |
| Failed junit tests | hadoop.hdfs.server.namenode.TestINodeAttributeProvider |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1945/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1945 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux b2bb8221c257 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 20eec95 |
| Default Java | 1.8.0_242 |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1945/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt |
| findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1945/1/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1945/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1945/1/testReport/ |
| Max. process+thread count | 3349 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1945/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
URL: https://github.com/apache/hadoop/pull/1945#issuecomment-611039899
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 19m 0s | trunk passed |
| +1 :green_heart: | compile | 1m 6s | trunk passed |
| +1 :green_heart: | checkstyle | 0m 47s | trunk passed |
| +1 :green_heart: | mvnsite | 1m 14s | trunk passed |
| +1 :green_heart: | shadedclient | 16m 9s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 45s | trunk passed |
| +0 :ok: | spotbugs | 2m 49s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 2m 48s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 8s | the patch passed |
| +1 :green_heart: | compile | 1m 2s | the patch passed |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| -0 :warning: | checkstyle | 0m 41s | hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 74 unchanged - 0 fixed = 75 total (was 74) |
| +1 :green_heart: | mvnsite | 1m 7s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 1s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 43s | the patch passed |
| +1 :green_heart: | findbugs | 2m 55s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 94m 41s | hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 42s | The patch does not generate ASF License warnings. |
| | | 160m 40s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.server.namenode.ha.TestHAAppend |
| | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
| | hadoop.hdfs.server.datanode.TestBPOfferService |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1945/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1945 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux ebaeb211c99c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 1189af4 |
| Default Java | 1.8.0_242 |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1945/2/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1945/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1945/2/testReport/ |
| Max. process+thread count | 4413 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1945/2/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] jojochuang commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
URL: https://github.com/apache/hadoop/pull/1945#issuecomment-610953798
Updated PR to include a nullity check inside setINodeAttributeProvider() which caused TestINodeAttributeProvider failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] jojochuang commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
URL: https://github.com/apache/hadoop/pull/1945#issuecomment-611618211
Thanks for verifying the performance and the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] jojochuang commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
URL: https://github.com/apache/hadoop/pull/1945#issuecomment-611339873
TestHAAppend doesn't reproduce locally.
TestUnderReplicatedBlocks and TestBPOfferService are failing (timeout) even before my patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] jojochuang merged pull request #1945: HDFS-15269. NameNode should check the authorization API version only …
Posted by GitBox <gi...@apache.org>.
jojochuang merged pull request #1945: HDFS-15269. NameNode should check the authorization API version only …
URL: https://github.com/apache/hadoop/pull/1945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tasanuma commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
Posted by GitBox <gi...@apache.org>.
tasanuma commented on issue #1945: HDFS-15269. NameNode should check the authorization API version only …
URL: https://github.com/apache/hadoop/pull/1945#issuecomment-611421431
Thanks for this PR, @jojochuang.
I ran Dynamometer using the real workload of our largest cluster. After HDFS-14743, READ/WRITE performance degraded by 13~14%. Then, with this PR, the performance came back as before HDFS-14743. Thanks for working on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org