You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Israel Ekpo <is...@aicer.org> on 2013/04/13 15:14:17 UTC
Review Request: FLUME-1889 - Add HBASE and ASYNC_HBASE enum types to SinkType
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10445/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Modified SyncType and SinkConfiguration to support this improvement.
This addresses bug FLUME-1889.
https://issues.apache.org/jira/browse/FLUME-1889
Diffs
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java c6c99d5
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java 7e0288e
Diff: https://reviews.apache.org/r/10445/diff/
Testing
-------
Thanks,
Israel Ekpo
Re: Review Request: FLUME-1889 - Add HBASE and ASYNC_HBASE enum types to
SinkType
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10445/#review19371
-----------------------------------------------------------
Israel, looks good to me. A couple of requests:
1. Please specify the testing done to ensure that this works.
2. Please update the Flume User Guide to document these new aliases.
3. Please clean up the end-of-line whitespace (highlighted here in red) and attach your patch to the JIRA.
Regards,
Mike
- Mike Percy
On April 13, 2013, 1:14 p.m., Israel Ekpo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10445/
> -----------------------------------------------------------
>
> (Updated April 13, 2013, 1:14 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Modified SyncType and SinkConfiguration to support this improvement.
>
>
> This addresses bug FLUME-1889.
> https://issues.apache.org/jira/browse/FLUME-1889
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java c6c99d5
> flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java 7e0288e
>
> Diff: https://reviews.apache.org/r/10445/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Israel Ekpo
>
>
Re: Review Request 10445: FLUME-1889 - Add HBASE and ASYNC_HBASE enum types
to SinkType
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10445/#review23300
-----------------------------------------------------------
Ship it!
Looks good to me, thanks!
- Alexander Alten-Lorenz
On April 24, 2013, 11:35 a.m., Israel Ekpo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10445/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 11:35 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-1889 and FLUME-1994
> https://issues.apache.org/jira/browse/FLUME-1889
> https://issues.apache.org/jira/browse/FLUME-1994
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Modified SyncType and SinkConfiguration to support this improvement.
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java c6c99d5
> flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java 7e0288e
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSinkCreation.java PRE-CREATION
> flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSinkCreation.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10445/diff/
>
>
> Testing
> -------
>
> The unit tests added simulate how these sinks are loaded.
>
>
> Thanks,
>
> Israel Ekpo
>
>
Re: Review Request: FLUME-1889 - Add HBASE and ASYNC_HBASE enum types to
SinkType
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10445/#review19937
-----------------------------------------------------------
Ship it!
Ship It!
- Hari Shreedharan
On April 24, 2013, 11:35 a.m., Israel Ekpo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10445/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 11:35 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Modified SyncType and SinkConfiguration to support this improvement.
>
>
> This addresses bugs FLUME-1889 and FLUME-1994.
> https://issues.apache.org/jira/browse/FLUME-1889
> https://issues.apache.org/jira/browse/FLUME-1994
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java c6c99d5
> flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java 7e0288e
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSinkCreation.java PRE-CREATION
> flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSinkCreation.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10445/diff/
>
>
> Testing
> -------
>
> The unit tests added simulate how these sinks are loaded.
>
>
> Thanks,
>
> Israel Ekpo
>
>
Re: Review Request: FLUME-1889 - Add HBASE and ASYNC_HBASE enum types to
SinkType
Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10445/
-----------------------------------------------------------
(Updated April 24, 2013, 11:35 a.m.)
Review request for Flume.
Description
-------
Modified SyncType and SinkConfiguration to support this improvement.
This addresses bugs FLUME-1889 and FLUME-1994.
https://issues.apache.org/jira/browse/FLUME-1889
https://issues.apache.org/jira/browse/FLUME-1994
Diffs
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java c6c99d5
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java 7e0288e
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSinkCreation.java PRE-CREATION
flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSinkCreation.java PRE-CREATION
Diff: https://reviews.apache.org/r/10445/diff/
Testing (updated)
-------
The unit tests added simulate how these sinks are loaded.
Thanks,
Israel Ekpo
Re: Review Request: FLUME-1889 - Add HBASE and ASYNC_HBASE enum types to
SinkType
Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10445/
-----------------------------------------------------------
(Updated April 24, 2013, 11:33 a.m.)
Review request for Flume.
Description
-------
Modified SyncType and SinkConfiguration to support this improvement.
This addresses bugs FLUME-1889 and FLUME-1994.
https://issues.apache.org/jira/browse/FLUME-1889
https://issues.apache.org/jira/browse/FLUME-1994
Diffs
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java c6c99d5
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java 7e0288e
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSinkCreation.java PRE-CREATION
flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSinkCreation.java PRE-CREATION
Diff: https://reviews.apache.org/r/10445/diff/
Testing
-------
Thanks,
Israel Ekpo
Re: Review Request: FLUME-1889 - Add HBASE and ASYNC_HBASE enum types to
SinkType
Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10445/
-----------------------------------------------------------
(Updated April 24, 2013, 11:33 a.m.)
Review request for Flume.
Changes
-------
Attached updated patch based on code review changes.
Also added unit tests.
Will upload the patch for the documentation changes in a separate code review.
Description
-------
Modified SyncType and SinkConfiguration to support this improvement.
This addresses bug FLUME-1889.
https://issues.apache.org/jira/browse/FLUME-1889
Diffs (updated)
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java c6c99d5
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java 7e0288e
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSinkCreation.java PRE-CREATION
flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSinkCreation.java PRE-CREATION
Diff: https://reviews.apache.org/r/10445/diff/
Testing
-------
Thanks,
Israel Ekpo