You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@auron.apache.org by "yew1eb (via GitHub)" <gi...@apache.org> on 2025/12/15 00:21:09 UTC

[PR] [AURON #1755] Use test-specific Log4j2 config in Maven test runs [auron]

yew1eb opened a new pull request, #1756:
URL: https://github.com/apache/auron/pull/1756

   <!--
     - Start the PR title with the related issue ID, e.g. '[AURON #XXXX] Short summary...'.
   -->
   # Which issue does this PR close?
   
   Closes #1755
   
   # Rationale for this change
   
   # What changes are included in this PR?
   
   # Are there any user-facing changes?
   
   # How was this patch tested?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AURON #1755] Use test-specific Log4j2 config in Maven test runs [auron]

Posted by "yew1eb (via GitHub)" <gi...@apache.org>.
yew1eb commented on code in PR #1756:
URL: https://github.com/apache/auron/pull/1756#discussion_r2618198123


##########
auron-core/src/test/resources/log4j2.properties:
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+rootLogger.level = info
+rootLogger.appenderRef.file.ref = File
+
+#File Appender
+appender.file.type = File
+appender.file.name = File
+appender.file.fileName = target/unit-tests.log

Review Comment:
   Yes. PTAL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AURON #1755] Use test-specific Log4j2 config in Maven test runs [auron]

Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1756:
URL: https://github.com/apache/auron/pull/1756#discussion_r2617877457


##########
auron-core/src/test/resources/log4j2.properties:
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+rootLogger.level = info
+rootLogger.appenderRef.file.ref = File
+
+#File Appender
+appender.file.type = File
+appender.file.name = File
+appender.file.fileName = target/unit-tests.log

Review Comment:
   Should we upload `unit-tests.log` when CI fails?
   
   https://github.com/apache/kyuubi/blob/39af9ca20589a79fac53d02471d8d09ed1b58a3e/.github/workflows/master.yml#L120-L126



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AURON #1755] Use test-specific Log4j2 config in Maven test runs [auron]

Posted by "richox (via GitHub)" <gi...@apache.org>.
richox merged PR #1756:
URL: https://github.com/apache/auron/pull/1756


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AURON #1755] Use test-specific Log4j2 config in Maven test runs [auron]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1756:
URL: https://github.com/apache/auron/pull/1756#discussion_r2618261648


##########
spark-extension/src/test/resources/log4j2.properties:
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+rootLogger.level = info
+rootLogger.appenderRef.file.ref = File

Review Comment:
   The console appender (STDOUT) is configured but never referenced in the rootLogger. Only the File appender is referenced, which means console output will be completely suppressed. To achieve the stated goal of reducing console noise to WARN level while still maintaining console output, add a console appender reference. The rootLogger configuration should include both appenders.
   ```suggestion
   rootLogger.appenderRef.file.ref = File
   rootLogger.appenderRef.console.ref = STDOUT
   ```



##########
common/src/test/resources/log4j2.properties:
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+rootLogger.level = info
+rootLogger.appenderRef.file.ref = File

Review Comment:
   The console appender (STDOUT) is configured but never referenced in the rootLogger. Only the File appender is referenced, which means console output will be completely suppressed. To achieve the stated goal of reducing console noise to WARN level while still maintaining console output, add a console appender reference. The rootLogger configuration should include both appenders.
   ```suggestion
   rootLogger.appenderRef.file.ref = File
   rootLogger.appenderRef.console.ref = STDOUT
   ```



##########
auron-core/src/test/resources/log4j2.properties:
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+rootLogger.level = info
+rootLogger.appenderRef.file.ref = File

Review Comment:
   The console appender (STDOUT) is configured but never referenced in the rootLogger. Only the File appender is referenced, which means console output will be completely suppressed. To achieve the stated goal of reducing console noise to WARN level while still maintaining console output, add a console appender reference. The rootLogger configuration should include both appenders.
   ```suggestion
   rootLogger.appenderRef.file.ref = File
   rootLogger.appenderRef.console.ref = STDOUT
   ```



##########
spark-extension-shims-spark/src/test/resources/log4j2.properties:
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+rootLogger.level = info
+rootLogger.appenderRef.file.ref = File

Review Comment:
   The console appender (STDOUT) is configured but never referenced in the rootLogger. Only the File appender is referenced, which means console output will be completely suppressed. To achieve the stated goal of reducing console noise to WARN level while still maintaining console output, add a console appender reference. The rootLogger configuration should include both appenders.
   ```suggestion
   rootLogger.appenderRef.file.ref = File
   rootLogger.appenderRef.stdout.ref = STDOUT
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org