You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/07/20 00:16:43 UTC
Review Request 60991: Changed Device::path to optional and introduced
Device::Number.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60991/
-----------------------------------------------------------
Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhongbo Tian.
Repository: mesos
Description
-------
A device in cgroup can be represented as either a path or a major:minor
number. Need to change the `required` Device::path to `optional` to
add Number in the device protobuf.
Diffs
-----
include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8
include/mesos/v1/mesos.proto 5e92e5d86023ad6edd94303fbde964bf403abf02
src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp ddf2a4d661001a3a5832c21504420223ca60a753
Diff: https://reviews.apache.org/r/60991/diff/1/
Testing
-------
make
Thanks,
Gilbert Song
Re: Review Request 60991: Changed Device::path to optional and
introduced Device::Number.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60991/#review181020
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On July 20, 2017, 8:16 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60991/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 8:16 a.m.)
>
>
> Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhongbo Tian.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A device in cgroup can be represented as either a path or a major:minor
> number. Need to change the `required` Device::path to `optional` to
> add Number in the device protobuf.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8
> include/mesos/v1/mesos.proto 5e92e5d86023ad6edd94303fbde964bf403abf02
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp ddf2a4d661001a3a5832c21504420223ca60a753
>
>
> Diff: https://reviews.apache.org/r/60991/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 60991: Changed Device::path to optional and
introduced Device::Number.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60991/#review181814
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On July 26, 2017, 1:01 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60991/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 1:01 a.m.)
>
>
> Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhongbo Tian.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A device in cgroup can be represented as either a path or a major:minor
> number. Need to change the `required` Device::path to `optional` to
> add Number in the device protobuf.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8f8079bd7c2de4e8b2f8f9a56e2731b77b8e1575
> include/mesos/v1/mesos.proto 720f307f8d738b0787e7c47be7ee15be38b2c0d0
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp ddf2a4d661001a3a5832c21504420223ca60a753
>
>
> Diff: https://reviews.apache.org/r/60991/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 60991: Changed Device::path to optional and
introduced Device::Number.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60991/
-----------------------------------------------------------
(Updated July 25, 2017, 6:01 p.m.)
Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhongbo Tian.
Repository: mesos
Description
-------
A device in cgroup can be represented as either a path or a major:minor
number. Need to change the `required` Device::path to `optional` to
add Number in the device protobuf.
Diffs (updated)
-----
include/mesos/mesos.proto 8f8079bd7c2de4e8b2f8f9a56e2731b77b8e1575
include/mesos/v1/mesos.proto 720f307f8d738b0787e7c47be7ee15be38b2c0d0
src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp ddf2a4d661001a3a5832c21504420223ca60a753
Diff: https://reviews.apache.org/r/60991/diff/2/
Changes: https://reviews.apache.org/r/60991/diff/1-2/
Testing
-------
make
Thanks,
Gilbert Song