You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/22 04:18:50 UTC
[GitHub] [flink] klion26 commented on a change in pull request #8479:
[FLINK-11193][State Backends]Use user passed configuration overriding
default configuration loading from file
klion26 commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file
URL: https://github.com/apache/flink/pull/8479#discussion_r286307041
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
##########
@@ -295,6 +297,7 @@ public RocksDBStateBackend(AbstractStateBackend checkpointStreamBackend, boolean
* @param classLoader The class loader.
*/
private RocksDBStateBackend(RocksDBStateBackend original, Configuration config, ClassLoader classLoader) {
+ this.configuration = config;
Review comment:
When do we use RocksDBStateBackend, seems we always use the **original** statebackend's conf first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services