You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/04/15 19:07:49 UTC

[GitHub] incubator-beam pull request: Uniformly apply toLowerCase for Dataf...

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/187

    Uniformly apply toLowerCase for Dataflow Job Names

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Also do minor cleanup of DataflowPIpelineOptions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam stop_lowercase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #187
    
----
commit 511ed61dc7d4e15c5e493a931d7e15b94d3b005c
Author: Thomas Groh <tg...@google.com>
Date:   2016-04-15T17:05:36Z

    Enforce JobName Preconditions in the Dataflow Runner
    
    This ensures that whenever a DataflowPipelineRunner is created, the
    jobName of the created options conforms to the requirements of the
    Dataflow Service.

commit 2edc88931472d7e38e26a117a7707417ff879e51
Author: Thomas Groh <tg...@google.com>
Date:   2016-04-15T17:06:21Z

    Clean up DataflowPipeline[Debug]Options
    
    getUpdate should be isUpdate, to meet standard JavaBeans style.
    
    Remove deprecated update property from DataflowPipelineDebugOptions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request: Uniformly apply toLowerCase for Dataf...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/187


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---