You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/30 23:14:25 UTC

[GitHub] [hudi] xushiyan commented on a change in pull request #4167: [HUDI-2880] Fixing loading of props from default dir

xushiyan commented on a change in pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#discussion_r759733359



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java
##########
@@ -119,7 +118,7 @@ public static void clearGlobalProps() {
    *
    * @param filePath File path for configuration file
    */
-  public void addPropsFromFile(Path filePath) {
+  public void addPropsFromFile(Path filePath, boolean isDefaultDirectory) {

Review comment:
       don't think we need extra param for this. if `filePath` is the default one, we know it by comparing it with `new Path(DEFAULT_CONF_FILE_DIR + "/" + DEFAULT_PROPERTIES_FILE)` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org