You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2024/01/06 12:39:36 UTC
[PR] [YUNIKORN-2312] Cleanup BinPacking e2e test workload before removing namespace [yunikorn-k8shim]
FrankYang0529 opened a new pull request, #761:
URL: https://github.com/apache/yunikorn-k8shim/pull/761
### What is this PR for?
In BinPacking e2e test, it creates two jobs without waiting for pod terminated. In AfterEach function, it calls `DeleteNamespace` without cleanup workloads. It's better to cleanup jobs before removing namespace.
https://github.com/apache/yunikorn-k8shim/blob/3e59ddcdd917c292635c6be0ddb8170356ae6511/test/e2e/bin_packing/bin_packing_test.go#L171-L204
### What type of PR is it?
* [X] - Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2312] Cleanup BinPacking e2e test workload before removing namespace [yunikorn-k8shim]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #761:
URL: https://github.com/apache/yunikorn-k8shim/pull/761#issuecomment-1879671900
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`3e59ddc`)](https://app.codecov.io/gh/apache/yunikorn-k8shim/commit/3e59ddcdd917c292635c6be0ddb8170356ae6511?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 71.27% compared to head [(`4eeaf69`)](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 71.30%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
+ Coverage 71.27% 71.30% +0.02%
==========================================
Files 43 43
Lines 7600 7600
==========================================
+ Hits 5417 5419 +2
+ Misses 1981 1979 -2
Partials 202 202
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2312] Cleanup BinPacking e2e test workload before removing namespace [yunikorn-k8shim]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #761:
URL: https://github.com/apache/yunikorn-k8shim/pull/761#issuecomment-1879777043
the failed e2e is traced by https://issues.apache.org/jira/browse/YUNIKORN-2313
will merge it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2312] Cleanup BinPacking e2e test workload before removing namespace [yunikorn-k8shim]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 closed pull request #761: [YUNIKORN-2312] Cleanup BinPacking e2e test workload before removing namespace
URL: https://github.com/apache/yunikorn-k8shim/pull/761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org